Merged
Conversation
|
|
…iredrakeproject/firedrake into dham/abstract_reduced_functional
JHopeCollins
previously approved these changes
Aug 12, 2025
Member
JHopeCollins
left a comment
JHopeCollins
left a comment
There was a problem hiding this comment.
This is ready to go. The only CI failure is an unrelated linkcheck
…keproject/firedrake into dham/abstract_reduced_functional
JHopeCollins
previously approved these changes
Aug 13, 2025
Member
JHopeCollins
left a comment
JHopeCollins
left a comment
There was a problem hiding this comment.
This is ready to go. The only CI failure is an unrelated linkcheck
JHopeCollins
approved these changes
Aug 13, 2025
angus-g
pushed a commit
to angus-g/firedrake
that referenced
this pull request
Aug 19, 2025
Co-authored-by: Daiane Iglesia Dolci <63597005+Ig-dolci@users.noreply.github.com> Co-authored-by: Josh Hope-Collins <joshua.hope-collins13@imperial.ac.uk> Co-authored-by: Pablo Brubeck <brubeck@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relies on: dolfin-adjoint/pyadjoint#156
The Firedrake changes are mostly internal, or only exposed if a user specifically requests them.
RieszMapobject for storing a persistent solver.EnsembleReducedFunctionalto inherit fromAbstractReducedFunctionalFunctionandCofunctionadjoint mixins.