Conversation
|
|
JHopeCollins
left a comment
There was a problem hiding this comment.
All good improvements. I just have a few suggestions for the PETSc installation details
rckirby
left a comment
There was a problem hiding this comment.
While clarifying install docs, perhaps we should add git+https to the suggested cloning commands for developer-mode install. Currently, it is http-only and one can't go over ssh/is prompted to supply GitHub credentials if one has followed the commands too slavishly.
rckirby
left a comment
There was a problem hiding this comment.
We need to make sure downstream packages installed in developer mode get installed via git
@rckirby I'm not quite sure what you mean by this? |
rckirby
left a comment
There was a problem hiding this comment.
But please delete the petsc/slepc version changes
|
Forcing this through as it was previously approved and is holding up other PRs. |
Description
firedrake-installpip cache remove petsc4pya main instruction so it isn't missedFixes #4097 and #4098
Note that the docs link check is expected to fail because it references a link that doesn't yet exist.
TODOs
--extra-index-url?)