Use apt for more PETSc packages on x86#4122
Conversation
|
You can "test" ARM by forcing GitHub actions to rebuild the containers like I do in #4104. Just make sure to give them a unique tag. |
Do we have an ARM label to specify the runner? |
|
Sort of. We use the macOS runners. I was suggesting rebuilding all of the containers, which will hit the ARM build. |
|
|
connorjward
left a comment
There was a problem hiding this comment.
I figured out why the Docker build is failing! It's sed: https://github.com/firedrakeproject/firedrake/blob/master/docker/Dockerfile.vanilla#L46. We overwrite COPTFLAGS and such to pass -mtune=generic so your extra settings aren't propagated. Could you maybe figure out a better bash command to just replace -march=native with -mtune=generic?
…edrakeproject/firedrake into JHopeCollins/more-apt-petsc-packages
Just had a go at a fix for this. |
JHopeCollins
left a comment
There was a problem hiding this comment.
UNDO BEFORE MERGE
connorjward
left a comment
There was a problem hiding this comment.
Looks 99% good to me. Ready to merge once these changes are committed.
Remove workflow edits for testing Co-authored-by: Connor Ward <c.ward20@imperial.ac.uk>
…om/firedrakeproject/firedrake into JHopeCollins/more-apt-petsc-packages
|
Forcing through as only failing due to a docs linkcheck fail. |
Description
We can use the apt binaries for a load more PETSc packages.
Works locally for x86. Will try with aarch64 once it works with x86 on CI.