Fold PyOP2/TSFC workflow into Firedrake one#4135
Merged
connorjward merged 5 commits intomasterfrom Apr 9, 2025
Merged
Conversation
connorjward
force-pushed
the
connorjward/workflow-cleanup
branch
from
705f380 to
a01294c
Compare
rckirby
approved these changes
Apr 9, 2025
pbrubeck
pushed a commit
that referenced
this pull request
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously had a separate workflow file for PyOP2 and TSFC tests. The motivation for doing this was that we could test those using multiple Python versions.
I believe that this is only a small benefit and not worth maintaining a separate workflow file for. Opinions are welcome.
Fixes #3818