Merged
Conversation
connorjward
reviewed
Apr 9, 2025
|
|
||
| .. _fig-tape: | ||
|
|
||
| .. figure:: images/tape.pdf |
Contributor
There was a problem hiding this comment.
Does this mean tape.pdf should be removed? Does it exist?
Member
Author
There was a problem hiding this comment.
🤷
Ideally these things should be being generated dynamically, but we need this for the tutorial this week and the .pdf only renders in Safari, but not Chrome and Firefox.
Member
Author
There was a problem hiding this comment.
I messed up, that should be an SVG anyway
Contributor
There was a problem hiding this comment.
Can you also remove the pdf? Just checked and it isn't used anywhere else so it shouldn't be left lying around.
JDBetteridge
force-pushed
the
JDBetteridge/fix_adjoint_notes
branch
from
4d57765 to
53d1f76
Compare
Member
Author
|
I removed this from |
JDBetteridge
force-pushed
the
JDBetteridge/fix_adjoint_notes
branch
from
53d1f76 to
5c3eecf
Compare
Member
Author
|
Okay, I put it back. You fixed it upstream whilst I was lecturing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description