Merged
Conversation
pbrubeck
force-pushed
the
pbrubeck/matis
branch
2 times, most recently
from
27c2f79 to
2c66987
Compare
connorjward
reviewed
Jun 25, 2025
wence-
reviewed
Jun 26, 2025
Contributor
wence-
left a comment
wence-
left a comment
There was a problem hiding this comment.
I think a bunch of the indexing is wrong when constructing the masked lgmaps?
pbrubeck
commented
Jul 1, 2025
pbrubeck
force-pushed
the
pbrubeck/matis
branch
8 times, most recently
from
f4a86f7 to
c715954
Compare
pbrubeck
force-pushed
the
pbrubeck/matis
branch
from
a929a79 to
6b7d89e
Compare
pbrubeck
commented
Sep 8, 2025
JHopeCollins
previously approved these changes
Oct 31, 2025
pbrubeck
commented
Oct 31, 2025
pbrubeck
commented
Oct 31, 2025
pbrubeck
commented
Oct 31, 2025
pbrubeck
force-pushed
the
pbrubeck/matis
branch
from
7b6a89a to
73cdcc2
Compare
pbrubeck
force-pushed
the
pbrubeck/matis
branch
from
af6b82d to
4800570
Compare
Contributor
|
The constant depends on the shape of the subdomains
Stefano
…On Mon, Nov 3, 2025, 1:42 PM Pablo Brubeck ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/firedrake/regression/test_bddc.py
<#4405 (comment)>
:
> bcs = True
tdim = mesh.topological_dimension
expected = 7 if tdim == 2 else 11
- assert solve_riesz_map(mesh, family, degree, bcs, condense) <= expected
+ assert solve_riesz_map(mesh, family, degree, variant, bcs, vector=vector) <= expected
+
+
***@***.***
***@***.***("family,degree", [("CG", 3), ("N1curl", 3), ("N1div", 3)])
+def test_bddc_aij_simplex(family, degree):
+ nx = 4
+ mesh = UnitCubeMesh(nx, nx, nx)
+ variant = None
+ bcs = True
+ expected = {"CG": 13, "N1curl": 14, "N1div": 12}[family]
Is there any constant in front of the upper bound? If not, then should we
expect kappa_{h/2} < kappa_h + log(2)?
—
Reply to this email directly, view it on GitHub
<#4405 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABHCKAOP45D43OPWRHERLTT324WTBAVCNFSM6AAAAACADRABKGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTIMJQGQYTONZYGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
Author
Very well. I have been generous with the constant, and assumed that the same type of bound holds for H(curl) and H(div) |
pbrubeck
commented
Nov 4, 2025
pbrubeck
commented
Nov 4, 2025
pbrubeck
commented
Nov 4, 2025
JHopeCollins
approved these changes
Nov 4, 2025
j-bowhay
pushed a commit
to j-bowhay/firedrake
that referenced
this pull request
Feb 24, 2026
* Support mat_type="is" * Support mat_type="nest", sub_mat_type="is" * Propagate sub_mat_type and only set sub_mat_type on the diagonal blocks * refine BDDC customization, use callables for gradient and divergence * Simplify coordinates handling of bddcpc driver * tabulate_exterior_derivative as MatIS * FDMPC: Support other variants * bddc: attach constants of the H(grad) space to discrete gradient * add mat_type kawrg to local_to_global_map * Test BDDC for H(curl) and H(div) --------- Co-authored-by: Stefano Zampini <stefano.zampini@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support
assemble(a, mat_type="is")Enables BDDC for problems in H(curl) and H(div)