Allow for solving multi-domain problems involving codim-1 submeshes#4430
Merged
Allow for solving multi-domain problems involving codim-1 submeshes#4430
Conversation
ksagiyam
force-pushed
the
ksagiyam/submesh_core_mixed_cell
branch
7 times, most recently
from
079ed6b to
6025421
Compare
ksagiyam
force-pushed
the
ksagiyam/submesh_core_mixed_cell
branch
from
435bbf0 to
55da4d5
Compare
ksagiyam
force-pushed
the
ksagiyam/submesh_core_mixed_cell
branch
2 times, most recently
from
86a6ce2 to
d215fc6
Compare
ksagiyam
force-pushed
the
ksagiyam/submesh_core_mixed_cell
branch
3 times, most recently
from
1209652 to
ce0b566
Compare
ksagiyam
force-pushed
the
ksagiyam/submesh_core_mixed_cell
branch
2 times, most recently
from
e54a35d to
2a28015
Compare
ksagiyam
force-pushed
the
ksagiyam/submesh_core_mixed_cell
branch
6 times, most recently
from
e74c776 to
7d53c13
Compare
ksagiyam
force-pushed
the
ksagiyam/submesh_core_mixed_cell
branch
7 times, most recently
from
1d8d50d to
49c5838
Compare
ksagiyam
force-pushed
the
ksagiyam/submesh_core_mixed_cell
branch
2 times, most recently
from
0d5adb2 to
f6e3b25
Compare
ksagiyam
force-pushed
the
ksagiyam/submesh_core_mixed_cell
branch
6 times, most recently
from
7b1e741 to
ad8ffef
Compare
ksagiyam
changed the title
ksagiyam
force-pushed
the
ksagiyam/submesh_core_mixed_cell
branch
4 times, most recently
from
a48c2a6 to
b8c8b19
Compare
ksagiyam
force-pushed
the
ksagiyam/submesh_core_mixed_cell
branch
4 times, most recently
from
e4309ca to
1794d05
Compare
connorjward
requested changes
Oct 29, 2025
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
Small testing cleanup
ksagiyam
force-pushed
the
ksagiyam/submesh_core_mixed_cell
branch
4 times, most recently
from
d58fdfb to
a95e394
Compare
Co-authored-by: Connor Ward <c.ward20@imperial.ac.uk>
ksagiyam
force-pushed
the
ksagiyam/submesh_core_mixed_cell
branch
from
a95e394 to
e76eb74
Compare
Contributor
Author
|
Only the known CI failures: documentation links check/Gusto/spyro tests. Merging as reviewed in the meetings + \alpha. |
Contributor
Not in sufficient depth to be meaningful. These changes are very substantial. This should have received an approving PR before going in. |
j-bowhay
pushed a commit
to j-bowhay/firedrake
that referenced
this pull request
Feb 24, 2026
…edrakeproject#4430) Co-authored-by: Connor Ward <c.ward20@imperial.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on:
FIAT: firedrakeproject/fiat#183
ufl: FEniCS/ufl#429
Allow for solving multi-domain problems involving codim-1 submeshes.