Skip to content

Do not set different cache directories per job #4460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
connorjward merged 4 commits into from
Jul 30, 2025
Merged

Do not set different cache directories per job #4460

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a2b40f
Do not set different cache directories per job
connorjward Jul 24, 2025
2be280b
Merge remote-tracking branch 'origin/release' into connorjward/unset-…
connorjward Jul 24, 2025
4a778c2
Empty commit
connorjward Jul 29, 2025
f2c5e28
Merge remote-tracking branch 'origin/release' into connorjward/unset-…
connorjward Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions scripts/firedrake-run-split-tests
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,6 @@ num_procs=$1
num_jobs=$2
extra_args=${@:3}

# Set per-job cache directories to avoid race conditions when multiple jobs attempt to compile the same form.
cache_cmd="PYOP2_CACHE_DIR=\$VIRTUAL_ENV/.cache/pyop2/job{#} \
FIREDRAKE_TSFC_KERNEL_CACHE_DIR=\$VIRTUAL_ENV/.cache/tsfc/job{#}"

if [ $num_procs = 1 ]; then
# Cannot use mpiexec -n 1 because this can sometimes hang with
# OpenMPI at MPI_Finalize
Expand All @@ -57,7 +53,7 @@ set -x
# * Uses tee to pipe stdout+stderr to both stdout and a log file
# * Writes pytest's exit code to a file called jobN.errcode (for later inspection)
parallel --line-buffer --tag \
"${cache_cmd}; ${pytest_cmd} |& tee ${log_file_prefix}{#}.log; \
"${pytest_cmd} |& tee ${log_file_prefix}{#}.log; \
echo \${PIPESTATUS[0]} > job{#}.errcode" \
::: $(seq ${num_jobs})

Expand Down
Loading