Assemble mixed cross-mesh interpolation operator #4792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to run through and make sure we collapse to unique mesh as appropriate
dham
requested changes
Jan 6, 2026
Member
dham
left a comment
dham
left a comment
There was a problem hiding this comment.
Apart from the style issue this looks good.
| def __init__(self, expr: Interpolate): | ||
| super().__init__(expr) | ||
| self.target_mesh = self.target_mesh.unique() | ||
| self.source_mesh = self.source_mesh.unique() |
Member
There was a problem hiding this comment.
rather than rewriting source_mesh and target_mesh, just call .unique() when they are used. This is likely to be less confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows assembly of interpolation matrices between mixed spaces over different domains.
Change default sub_mat_type for nested MixedInterpolator from 'baij' to 'aij' for greater compatibility.