Remove tests without taping from adjoint test directory.#4870
Merged
JHopeCollins merged 9 commits intomainfrom Feb 10, 2026
Merged
Remove tests without taping from adjoint test directory.#4870JHopeCollins merged 9 commits intomainfrom
JHopeCollins merged 9 commits intomainfrom
Conversation
JHopeCollins
changed the base branch from
main
to
JHopeCollins/reduce-adjoint-tests-global-state
…opeCollins/only-taped-tests-in-adjoint-dir
….com:firedrakeproject/firedrake into JHopeCollins/only-taped-tests-in-adjoint-dir
connorjward
previously approved these changes
Feb 10, 2026
Base automatically changed from
JHopeCollins/reduce-adjoint-tests-global-state
to
main
February 10, 2026 11:54
JHopeCollins
dismissed
connorjward’s stale review
The base branch was changed.
connorjward
approved these changes
Feb 10, 2026
JHopeCollins
deleted the
JHopeCollins/only-taped-tests-in-adjoint-dir
branch
leo-collins
pushed a commit
that referenced
this pull request
Feb 17, 2026
j-bowhay
pushed a commit
to j-bowhay/firedrake
that referenced
this pull request
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bunch of the tests for the
CovarianceOperatorPR do not use any taping. But because the code is infiredrake.adjointI put all the tests intests/firedrake/adjoint, which means that they are run by the pyadjoint CI.Some of the non-taped tests are quite chunky tests because they are checking statistical convergence of noise generation, but don't actually test any pyadjoint functionality.
This PR splits the covariance tests so that only the ones using taping remain in
tests/firedrake/adjointto be run by the pyadjoint CI.To be merged into or after #4867