-
Notifications
You must be signed in to change notification settings - Fork 1
WIP: Namespaced AppContext
#16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
JHopeCollins
wants to merge
15
commits into
main
Choose a base branch
from
JHopeCollins/appctx
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 3 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
8d680b1
appctx
JHopeCollins 321fefa
Merge branch 'main' into JHopeCollins/appctx
JHopeCollins 54cd6db
AppContext in __init__
JHopeCollins 4604f3d
Merge branch 'main' into JHopeCollins/appctx
JHopeCollins c7e366a
Hide AppContext internal keys from user
JHopeCollins 913eb56
updates
JHopeCollins cfe9954
appctx docstrings
JHopeCollins ec9c900
test appctx
JHopeCollins 0a4ba8f
tidy up appctx keygen
JHopeCollins 8104028
review comments - hide key from user completely
JHopeCollins d231b36
move import to top of test file
JHopeCollins 36587cc
Update petsctools/appctx.py
JHopeCollins 3c1b6cf
appctx: hide key_from_option from user.
JHopeCollins 5975b82
global appctx stack
JHopeCollins d51cd25
numpy import inside test
JHopeCollins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import itertools | ||
|
|
||
|
|
||
| class AppContext: | ||
connorjward marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| def __init__(self): | ||
| self._count = itertools.count() | ||
| self._data = {} | ||
| self._missing_key = next(self._count) | ||
|
|
||
| @property | ||
| def missing_key(self): | ||
| return self._missing_key | ||
|
|
||
| def insert(self, val): | ||
| key = next(self._count) | ||
| self._data[key] = val | ||
| return key | ||
|
|
||
| def __getitem__(self, key): | ||
| return self._data[key] | ||
|
|
||
| def get(self, key, default=None): | ||
| if key == self.missing_key: | ||
JHopeCollins marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| return default | ||
| return self._data.get(key, default=default) | ||
|
|
||
| def values(self): | ||
| return self._data.values() | ||
JHopeCollins marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.