Skip to content
This repository was archived by the owner on Sep 21, 2021. It is now read-only.

Commit 27b1048

Browse files
committed
Don't use a closure to expose the ObjectInspector store.
This was causing a leak in a mochitest in mozilla-central.
1 parent bfec9eb commit 27b1048

File tree

1 file changed

+12
-4
lines changed
  • packages/devtools-reps/src/object-inspector

1 file changed

+12
-4
lines changed

packages/devtools-reps/src/object-inspector/index.js

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,25 @@ const { Provider } = require("react-redux");
88
const ObjectInspector = createFactory(require("./component"));
99
const createStore = require("./store");
1010

11-
let store;
11+
import type { Props, State } from "./types";
12+
1213
class OI extends PureComponent {
14+
15+
constructor(props: Props) {
16+
super(props);
17+
this.store = createStore(props);
18+
}
19+
20+
store: {dispatch: (any) => any, getState: () => State};
21+
1322
getStore() {
14-
return store;
23+
return this.store;
1524
}
1625

1726
render() {
18-
store = createStore(this.props);
1927
return createElement(
2028
Provider,
21-
{store},
29+
{store: this.store},
2230
ObjectInspector(this.props)
2331
);
2432
}

0 commit comments

Comments
 (0)