Add additional fullText tests

and use ELLIPSIS constant in string rep tests

Author: 2007heaven

packages/devtools-reps/src/reps/tests/long-string.js

@@ -8,6 +8,10 @@ const {
   getRep,
 } = require("../rep");
 
+const {
+  ELLIPSIS,
+} = require("../rep-utils");
+
 const {
   expectActorAttribute,
 } = require("./test-helpers");
@@ -32,7 +36,8 @@ describe("long StringRep", () => {
       object: stub
     }));
 
-    expect(renderedComponent.text()).toEqual(quoteNewlines(`"${stub.initial}…"`));
+    expect(renderedComponent.text())
+      .toEqual(quoteNewlines(`"${stub.initial}${ELLIPSIS}"`));
     expectActorAttribute(renderedComponent, stub.actor);
   });
 
@@ -44,7 +49,7 @@ describe("long StringRep", () => {
       cropLimit: 20
     }));
 
-    expect(renderedComponent.text()).toEqual(`"a\\naaaaaaaaaaaaaaaaaa…"`);
+    expect(renderedComponent.text()).toEqual(`"a\\naaaaaaaaaaaaaaaaaa${ELLIPSIS}"`);
   });
 
   it("renders with expected text content for multiline string when open", () => {
@@ -56,7 +61,7 @@ describe("long StringRep", () => {
     }));
 
     expect(renderedComponent.text())
-      .toEqual(quoteNewlines(`"${stub.initial}…"`));
+      .toEqual(quoteNewlines(`"${stub.initial}${ELLIPSIS}"`));
   });
 
   it("renders with expected text content when grip has a fullText" +
@@ -79,7 +84,7 @@ describe("long StringRep", () => {
       cropLimit: 20
     }));
 
-    expect(renderedComponent.text()).toEqual(`"a\\naaaaaaaaaaaaaaaaaa…"`);
+    expect(renderedComponent.text()).toEqual(`"a\\naaaaaaaaaaaaaaaaaa${ELLIPSIS}"`);
   });
 
   it("expected to omit quotes", () => {
@@ -92,6 +97,7 @@ describe("long StringRep", () => {
 
     expect(renderedComponent.html())
     .toEqual('<span data-link-actor-id="server1.conn1.child1/longString58" ' +
-             'class="objectBox objectBox-string">a\naaaaaaaaaaaaaaaaaa…</span>');
+             `class="objectBox objectBox-string">a\naaaaaaaaaaaaaaaaaa${ELLIPSIS}` +
+             "</span>");
   });
 });

packages/devtools-reps/src/reps/tests/string.js

@@ -3,6 +3,7 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 const { shallow } = require("enzyme");
+const { ELLIPSIS } = require("../rep-utils");
 const { REPS } = require("../rep");
 const { Rep } = REPS;
 
@@ -18,7 +19,7 @@ const testCases = [{
     object: "aaaaaaaaaaaaaaaaaaaaa\nbbbbbbbbbbbbbbbbbbb\ncccccccccccccccc\n",
     cropLimit: 20
   },
-  result: "\"aaaaaaaaa…cccccc\\n\""
+  result: `\"aaaaaaaaa${ELLIPSIS}cccccc\\n\"`
 }, {
   name: "testMultilineOpen",
   props: {
@@ -70,6 +71,31 @@ const testCases = [{
     escapeWhitespace: false,
   },
   result: "\"line 1\r\nline 2\n\tline 3\""
+}, {
+  name: "testIgnoreFullTextWhenOpen",
+  props: {
+    object: "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
+    fullText: "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
+    member: {open: true},
+  },
+  result: "\"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\""
+}, {
+  name: "testIgnoreFullTextWithLimit",
+  props: {
+    object: "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
+    fullText: "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
+    cropLimit: 20,
+  },
+  result: `\"aaaaaaaaa${ELLIPSIS}aaaaaaaa\"`
+}, {
+  name: "testIgnoreFullTextWhenOpenWithLimit",
+  props: {
+    object: "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
+    fullText: "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
+    member: {open: true},
+    cropLimit: 20,
+  },
+  result: "\"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\""
 }];
 
 describe("test String", () => {