Increase the upload limit to 150 MB and update the error message in logs (#443)

Author: julienw

src/routes/publish.ts

@@ -24,7 +24,7 @@ import {
 import { encode as toBase32 } from '../utils/base32';
 import { PayloadTooLargeError } from '../utils/errors';
 
-const MAX_BODY_LENGTH = 50 * 1024 * 1024; // 50MB
+const MAX_BODY_LENGTH = 150 * 1024 * 1024; // 150MB
 
 const randomBytes = promisify(crypto.randomBytes);
 
@@ -55,9 +55,9 @@ export function publishRoutes() {
     if (expectedLength !== undefined && expectedLength > MAX_BODY_LENGTH) {
       log.verbose(
         'length-header-check',
-        'The length specified in the header Content-Length is too big.'
+        `The length specified in the header Content-Length (${expectedLength}) is too big.`
       );
-      throw new PayloadTooLargeError(MAX_BODY_LENGTH);
+      throw new PayloadTooLargeError(MAX_BODY_LENGTH, expectedLength);
     }
 
     const profileToken = await generateTokenForProfile();

src/utils/errors.ts

@@ -27,9 +27,10 @@ export class PayloadTooLargeError extends Error {
   status = 413;
   expose = true;
 
-  constructor(maxPayloadSize: number) {
-    super(
-      `The length is bigger than the configured maximum ${maxPayloadSize}.`
-    );
+  constructor(maxPayloadSize: number, receivedPayloadSize?: number) {
+    const message = receivedPayloadSize
+      ? `The received length ${receivedPayloadSize} is bigger than the configured maximum ${maxPayloadSize}.`
+      : `The length is bigger than the configured maximum ${maxPayloadSize}.`;
+    super(message);
   }
 }

test/api/publish.test.ts

@@ -109,14 +109,28 @@ describe('publishing endpoints', () => {
     expectBucketHasProfile(profileToken);
   });
 
+  it('also works for length between 50MB and 150MB', async () => {
+    const payload = gzipSync(`{"foo": "${'#'.repeat(55 * 1024 * 1024)}"}`, {
+      level: 0,
+    });
+    const req = getPreconfiguredRequest();
+    await req
+      .set('Content-Length', String(payload.length))
+      .send(payload)
+      .expect(200);
+  });
+
   it('returns an error when the length header is too big', async () => {
     jest
       .spyOn(process.stdout, 'write')
       .mockImplementation((_: string | Uint8Array) => true);
     const req = getPreconfiguredRequest();
     await req
       .set('Content-Length', String(1024 * 1024 * 1024))
-      .expect(413, /The length is bigger than the configured maximum/);
+      .expect(
+        413,
+        /The received length \d+ is bigger than the configured maximum/
+      );
     expect(process.stdout.write).toHaveBeenCalledWith(
       expect.stringContaining('server_error')
     );
@@ -131,8 +145,8 @@ describe('publishing endpoints', () => {
     // When using the low-level API "write", Node generates a "chunked encoding"
     // request without a Content-Length. This is exactly what we want to check
     // here.
-    // We generate a Buffer of ~51MB, but our limit is 50MB.
-    const payload = gzipSync(`{"foo": "${'#'.repeat(51 * 1024 * 1024)}"}`, {
+    // We generate a Buffer of ~151MB, but our limit is 150MB.
+    const payload = gzipSync(`{"foo": "${'#'.repeat(151 * 1024 * 1024)}"}`, {
       level: 0,
     });
     await req.write(payload);