Skip to content

Commit 48c7847

Browse files
mstangemstange
authored
Some path fixes (#5581)
[Production](https://profiler.firefox.com/public/g09y396tf8e5ga5cc1k8ec2wxet3acg4hx27pw8/calltree/?globalTrackOrder=9a08w312&hiddenGlobalTracks=1w6&hiddenLocalTracksByPid=48531-1w3~48542-0~48534-0~48536-0~48545-0~48544-0~48543-0&thread=c&v=11) | [Deploy preview](https://deploy-preview-5581--perf-html.netlify.app/public/g09y396tf8e5ga5cc1k8ec2wxet3acg4hx27pw8/calltree/?globalTrackOrder=9a08w312&hiddenGlobalTracks=1w6&hiddenLocalTracksByPid=48531-1w3~48542-0~48534-0~48536-0~48545-0~48544-0~48543-0&thread=c&v=11) Two changes: 1. Fix the link preload path to app.ftl to be absolute 2. Consistently use firefox-profiler-res paths in CSS files
2 parents 93fd5d9 + d2018d5 commit 48c7847

File tree

12 files changed

+34
-30
lines changed

12 files changed

+34
-30
lines changed

‎res/index.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<meta charset="utf-8" />
88
<meta name="viewport" content="initial-scale=1" />
99
<title>Firefox Profiler</title>
10-
<link rel="preload" href="locales/en-US/app.ftl" as="fetch" />
10+
<link rel="preload" href="/locales/en-US/app.ftl" as="fetch" />
1111
</head>
1212
<body style="background-color: #363959; /* ink-70 */">
1313
<svg id="svg-filters"></svg>

‎src/components/app/BottomBox.css‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,11 @@
7272
}
7373

7474
.bottom-close-button {
75-
background-image: url(/res/img/svg/close-dark.svg);
75+
background-image: url(firefox-profiler-res/img/svg/close-dark.svg);
7676
}
7777

7878
.bottom-assembly-button {
79-
background-image: url(/res/img/svg/asm-icon.svg);
79+
background-image: url(firefox-profiler-res/img/svg/asm-icon.svg);
8080
}
8181

8282
.codeLoadingOverlay,
@@ -111,7 +111,8 @@
111111
width: 32px;
112112
height: 32px;
113113
flex-shrink: 0;
114-
background: url(/res/img/spinner.png) center center / 32px 32px no-repeat;
114+
background: url(firefox-profiler-res/img/spinner.png) center center / 32px
115+
32px no-repeat;
115116
content: '';
116117
}
117118

@@ -122,7 +123,8 @@
122123
width: 50px;
123124
height: 50px;
124125
flex-shrink: 0;
125-
background: url(/res/img/svg/error.svg) center center / 32px 32px no-repeat;
126+
background: url(firefox-profiler-res/img/svg/error.svg) center center / 32px
127+
32px no-repeat;
126128
content: '';
127129
filter: brightness(70%) drop-shadow(0 1px rgb(255 255 255 / 0.5));
128130
}

‎src/components/app/Details.css‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@
2626
}
2727

2828
.sidebar-open-close-button-isopen {
29-
background-image: url(../../../res/img/svg/pane-collapse.svg);
29+
background-image: url(firefox-profiler-res/img/svg/pane-collapse.svg);
3030
}
3131

3232
.sidebar-open-close-button-isclosed {
33-
background-image: url(../../../res/img/svg/pane-expand.svg);
33+
background-image: url(firefox-profiler-res/img/svg/pane-expand.svg);
3434
}

‎src/components/app/Home.css‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@
145145
width: 20px;
146146
height: 20px;
147147
margin: 0 10px -4px 3px;
148-
background: url(../../../res/img/svg/help-blue.svg);
148+
background: url(firefox-profiler-res/img/svg/help-blue.svg);
149149
background-size: 100% 100%;
150150
}
151151

‎src/components/app/KeyboardShortcut.css‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,8 @@
9595

9696
/* Allow for the photon focus ring to fit in the space by using a 4px margin. */
9797
margin: 4px;
98-
background: url(../../../res/img/svg/searchfield-cancel.svg) 10px center
99-
no-repeat;
98+
background: url(firefox-profiler-res/img/svg/searchfield-cancel.svg) 10px
99+
center no-repeat;
100100
cursor: pointer;
101101
font-size: inherit;
102102
}

‎src/components/app/ProfileDeleteButton.css‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
/* Note: 20px is: 16px (icon width) + 4px (distance from the text) */
77
padding-left: 20px;
88
margin: 0;
9-
background: url(../../../res/img/svg/check-dark.svg) no-repeat left / 16px
10-
16px;
9+
background: url(firefox-profiler-res/img/svg/check-dark.svg) no-repeat left /
10+
16px 16px;
1111
white-space: nowrap;
1212
}
1313

@@ -16,8 +16,8 @@
1616
padding-left: 24px;
1717

1818
/* The icon is 4px below the top */
19-
background: url(../../../res/img/svg/error-red.svg) no-repeat 0 4px / 16px
20-
16px;
19+
background: url(firefox-profiler-res/img/svg/error-red.svg) no-repeat 0 4px /
20+
16px 16px;
2121
color: var(--red-60);
2222
overflow-wrap: break-word;
2323
}

‎src/components/app/ProfileViewer.css‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@
8080
margin: 3px 0 3px 3px;
8181

8282
/* Other */
83-
background: var(--green-50) url(../../../res/img/svg/back-arrow.svg) center
84-
center no-repeat;
83+
background: var(--green-50) url(firefox-profiler-res/img/svg/back-arrow.svg)
84+
center center no-repeat;
8585
color: #000;
8686
}
8787

‎src/components/calltree/CallTree.css‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,5 +32,5 @@
3232

3333
.treeBadge.inlined,
3434
.treeBadge.divergent-inlining {
35-
background: url(../../../res/img/svg/inlined-icon.svg);
35+
background: url(firefox-profiler-res/img/svg/inlined-icon.svg);
3636
}

‎src/components/shared/IdleSearchField.css‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
position: relative;
2222
flex: 1;
2323
margin: 0;
24-
background: url(../../../res/img/svg/searchfield-icon.svg) 3px center
24+
background: url(firefox-profiler-res/img/svg/searchfield-icon.svg) 3px center
2525
no-repeat white;
2626
background-size: 11px 11px;
2727
}
@@ -34,7 +34,7 @@
3434
height: 11px;
3535
padding: 0;
3636
border: 0;
37-
background: url(../../../res/img/svg/searchfield-cancel.svg) top left
37+
background: url(firefox-profiler-res/img/svg/searchfield-cancel.svg) top left
3838
no-repeat;
3939
background-size: contain;
4040
color: transparent;

‎src/components/shared/ProfileMetaInfoSummary.css‎

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,32 +20,34 @@
2020

2121
.profileMetaInfoSummaryProductAndVersion {
2222
padding-left: 1.4em; /* 1 (for the background image) + 0.4 */
23-
background: url(../../../res/img/svg/info.svg) left center / 1em no-repeat;
23+
background: url(firefox-profiler-res/img/svg/info.svg) left center / 1em
24+
no-repeat;
2425
}
2526

2627
.profileMetaInfoSummaryProductAndVersion[data-product^='Firefox'],
2728
.profileMetaInfoSummaryProductAndVersion[data-product='Fennec'] {
28-
background-image: url(../../../res/img/svg/brands/firefoxbrowser.svg);
29+
background-image: url(firefox-profiler-res/img/svg/brands/firefoxbrowser.svg);
2930
}
3031

3132
.profileMetaInfoSummaryPlatform {
3233
padding-left: 1.4em; /* 1 (for the background image) + 0.4 */
3334
margin-left: 1em;
34-
background: url(../../../res/img/svg/info.svg) left center / 1em no-repeat;
35+
background: url(firefox-profiler-res/img/svg/info.svg) left center / 1em
36+
no-repeat;
3537
}
3638

3739
.profileMetaInfoSummaryPlatform[data-toolkit^='macOS'] {
38-
background-image: url(../../../res/img/svg/brands/apple.svg);
40+
background-image: url(firefox-profiler-res/img/svg/brands/apple.svg);
3941
}
4042

4143
.profileMetaInfoSummaryPlatform[data-toolkit^='Windows'] {
42-
background-image: url(../../../res/img/svg/brands/windows.svg);
44+
background-image: url(firefox-profiler-res/img/svg/brands/windows.svg);
4345
}
4446

4547
.profileMetaInfoSummaryPlatform[data-toolkit^='Linux'] {
46-
background-image: url(../../../res/img/svg/brands/linux.svg);
48+
background-image: url(firefox-profiler-res/img/svg/brands/linux.svg);
4749
}
4850

4951
.profileMetaInfoSummaryPlatform[data-toolkit^='Android'] {
50-
background-image: url(../../../res/img/svg/brands/android.svg);
52+
background-image: url(firefox-profiler-res/img/svg/brands/android.svg);
5153
}

0 commit comments

Comments
 (0)