Make binary profile format parsing use Uint8Array instead of ArrayBuffer #5678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uint8Array is more flexible because it can refer to a subrange within a bigger ArrayBuffer.
This is a more natural fit and avoids the copy in symbolicator-cli.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5678 +/- ##
=======================================
Coverage 85.62% 85.62%
=======================================
Files 312 312
Lines 30879 30880 +1
Branches 8413 8512 +99
=======================================
+ Hits 26440 26441 +1
Misses 4009 4009
Partials 430 430 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
canova
approved these changes
Nov 18, 2025
Member
canova
left a comment
canova
left a comment
There was a problem hiding this comment.
Oh looks like I forgot to submit the review. Looks good to me, thanks!
canova
added a commit
that referenced
this pull request
Dec 18, 2025
Changes: [Markus Stange] Use a longer test timeout when debugging with VS code. (#5679) [Markus Stange] Move Jest config from package.json to jest.config.js (#5680) [Markus Stange] Make binary profile format parsing use Uint8Array instead of ArrayBuffer (#5678) [Markus Stange] Use workbox-cli to generate the service worker (#5681) [Nazım Can Altınova] Migrate from Appveyor to GitHub Actions Windows runners (#5660) [Nazım Can Altınova] Remove some unused dependencies (#5696) [Nazım Can Altınova] Update the document links and sections (#5705) [Nazım Can Altınova] Clear selected and expanded call node paths on browser back button if it removes transforms (#5701) [Nazım Can Altınova] Properly type the Map and Set objects (#5623) [Valentin Gosu] Add priorityHeader field to network requests (#5707) [Nazım Can Altınova] Redirect unpublished url loads to the homepage similar to from-file (#5712) [Florian Quèze/Nazım Can Altınova] Add an importer for the text format taken as input by flamegraph.pl. (#5359) [Florian Quèze] Improve the import of profiles generated from clang -ftime-trace=file.json (#5714) [Markus Stange] Move React stuff out of marker schema logic module. (#5720) And thanks to our localizers: en-CA: chutten en-CA: Paul es-CL: ravmn fr: Théo Chevalier fur: Fabio Tomat ru: berry tr: Selim Şumlu zh-CN: Olvcpr423 zh-CN: wxie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accepting an ArrayBuffer is a bit restrictive because it means the buffer has to be sized to exactly contain the profile bytes and nothing else. Accepting a Uint8Array is more flexible because the Uint8Array can refer to just the sub-part of the buffer that actually contains the profile.
This lets us avoid a copy in symbolicator-cli.