Skip to content

Always consider markers in time range for thread #5682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nordzilla wants to merge 1 commit into from
Closed

Always consider markers in time range for thread #5682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/profile-logic/profile-data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1267,9 +1267,13 @@ function _getTimeRangeForThread(
}
result.end = accumTime + interval;
}
} else if (markers.length) {
// Looking at the markers only if there are no samples in the profile.
// We need to look at those because it can be a marker only profile(no-sampling mode).
}

if (markers.length) {
// Also check markers to ensure the timeline extends to cover all marker data.
// This is necessary both for marker-only profiles (no-sampling mode) and for
// profiles where markers may extend beyond the last sample.

// Finding start and end times sadly requires looping through all markers :(
for (let i = 0; i < markers.length; i++) {
const maybeStartTime = markers.startTime[i];
Expand Down
Loading