Skip to content

Construct new stack tables with the correct column lengths#5906

Merged
canova merged 2 commits intofirefox-devtools:mainfrom
mstange:push-qvywvmzzsttt
Mar 24, 2026
Merged

Construct new stack tables with the correct column lengths#5906
canova merged 2 commits intofirefox-devtools:mainfrom
mstange:push-qvywvmzzsttt

Conversation

@mstange
Copy link
Copy Markdown
Contributor

@mstange mstange commented Mar 23, 2026

Fixes #5905.

@mstange mstange requested a review from canova March 23, 2026 18:10
@mstange mstange self-assigned this Mar 23, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026

Codecov Report

❌ Patch coverage is 82.08955% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.41%. Comparing base (f8bed2b) to head (a6bf146).
⚠️ Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
src/profile-logic/transforms.ts 85.71% 4 Missing and 4 partials ⚠️
src/profile-logic/profile-data.ts 63.63% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5906      +/-   ##
==========================================
- Coverage   85.45%   85.41%   -0.05%     
==========================================
  Files         321      321              
  Lines       32081    32163      +82     
  Branches     8842     8784      -58     
==========================================
+ Hits        27416    27471      +55     
- Misses       4233     4256      +23     
- Partials      432      436       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@canova canova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, let's land it and deploy.

There are some code duplication that could be improved, but let's land it to fix the issue first and we can think about follow-ups later.

@canova canova enabled auto-merge (squash) March 24, 2026 13:01
@canova canova merged commit 33c9f6a into firefox-devtools:main Mar 24, 2026
19 checks passed
@canova canova mentioned this pull request Mar 24, 2026
canova added a commit that referenced this pull request Mar 24, 2026
Changes:

[Nazım Can Altınova] Display relative sources correctly in the source
view using startLine from the source table (#5902)
[dependabot[bot]] Bump flatted from 3.3.3 to 3.4.2 (#5904)
[Markus Stange] Construct new stack tables with the correct column
lengths. (#5906)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash when hovering thread sample graph when a focus-function transform is applied

2 participants