Skip to content

Propagate isJS to symbolicated funcs#5907

Open
mstange wants to merge 1 commit intofirefox-devtools:mainfrom
mstange:push-tvzzmrryuxmx
Open

Propagate isJS to symbolicated funcs#5907
mstange wants to merge 1 commit intofirefox-devtools:mainfrom
mstange:push-tvzzmrryuxmx

Conversation

@mstange
Copy link
Copy Markdown
Contributor

@mstange mstange commented Mar 23, 2026

I'm currently testing a mode in samply where native symbolication supplies the name for JS functions. This means that we now have frames which are both "JS" and "native" at the same time - they should be visible in the JS-only call tree, but they also have a native library and an address and can get their names by symbolicating an address.

One thing I noticed is that, when symbolication has to add new funcs to the func table, these funcs always had isJS == false. But when symbolicating JS frames via native symbolication, we actually want to propagate isJS from the unsymbolicated function.

Here's a badly-symbolicated example: https://share.firefox.dev/4d0sYMp
The function intersect disappears in JS-only mode.

(The above profile also demonstrates inline symbolication but I realize now that the actual bug doesn't require inlining at all.)

@mstange mstange requested a review from canova March 23, 2026 21:50
@mstange mstange force-pushed the push-tvzzmrryuxmx branch 2 times, most recently from c3726e1 to 7947ba5 Compare March 23, 2026 21:53
@mstange mstange force-pushed the push-tvzzmrryuxmx branch from 7947ba5 to e4ef68b Compare March 24, 2026 15:26
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.44%. Comparing base (cb9c976) to head (e4ef68b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5907      +/-   ##
==========================================
+ Coverage   85.42%   85.44%   +0.02%     
==========================================
  Files         321      321              
  Lines       32168    32170       +2     
  Branches     8785     8869      +84     
==========================================
+ Hits        27479    27489      +10     
+ Misses       4253     4245       -8     
  Partials      436      436              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant