Propagate isJS to symbolicated funcs#5907
Open
mstange wants to merge 1 commit intofirefox-devtools:mainfrom
Open
Propagate isJS to symbolicated funcs#5907mstange wants to merge 1 commit intofirefox-devtools:mainfrom
mstange wants to merge 1 commit intofirefox-devtools:mainfrom
Conversation
c3726e1 to
7947ba5
Compare
7947ba5 to
e4ef68b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5907 +/- ##
==========================================
+ Coverage 85.42% 85.44% +0.02%
==========================================
Files 321 321
Lines 32168 32170 +2
Branches 8785 8869 +84
==========================================
+ Hits 27479 27489 +10
+ Misses 4253 4245 -8
Partials 436 436 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm currently testing a mode in samply where native symbolication supplies the name for JS functions. This means that we now have frames which are both "JS" and "native" at the same time - they should be visible in the JS-only call tree, but they also have a native library and an address and can get their names by symbolicating an address.
One thing I noticed is that, when symbolication has to add new funcs to the func table, these funcs always had
isJS == false. But when symbolicating JS frames via native symbolication, we actually want to propagateisJSfrom the unsymbolicated function.Here's a badly-symbolicated example: https://share.firefox.dev/4d0sYMp
The function
intersectdisappears in JS-only mode.(The above profile also demonstrates inline symbolication but I realize now that the actual bug doesn't require inlining at all.)