Allow exporting argument values in profiles#5914
Open
squarewave wants to merge 2 commits intofirefox-devtools:mainfrom
Open
Allow exporting argument values in profiles#5914squarewave wants to merge 2 commits intofirefox-devtools:mainfrom
squarewave wants to merge 2 commits intofirefox-devtools:mainfrom
Conversation
I'm not actually sure why I initially put this in here - I think it was just overzealous flow type fixing that I then ported blindly to typescript when I had to update the patches.
This adds a checkbox which will allow the user to include argument values in exported profiles. The export also respects the checkbox to only export the specified timerange by reconstructing the values buffer to only include arguments referenced by included samples.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5914 +/- ##
==========================================
- Coverage 85.41% 85.35% -0.07%
==========================================
Files 321 321
Lines 32157 32201 +44
Branches 8865 8794 -71
==========================================
+ Hits 27468 27486 +18
- Misses 4253 4279 +26
Partials 436 436 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
flodolo
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a checkbox which will allow the user to include argument values in exported profiles. The export also respects the checkbox to only export the specified timerange by reconstructing the values buffer to only include arguments referenced by included samples.