Skip to content

Use createStackTableBySkippingDiscarded in focusSelf.#5916

Open
mstange wants to merge 1 commit intofirefox-devtools:mainfrom
mstange:push-zwnlpzpnrzqw
Open

Use createStackTableBySkippingDiscarded in focusSelf.#5916
mstange wants to merge 1 commit intofirefox-devtools:mainfrom
mstange:push-zwnlpzpnrzqw

Conversation

@mstange
Copy link
Copy Markdown
Contributor

@mstange mstange commented Mar 26, 2026

Fixes #5915.

Before this fix, we were keeping the filtered-out stacks in the stack table. Now we create a stack table which has those stacks removed. A smaller stack table makes all the follow-on work faster.

Before: https://share.firefox.dev/4bXlszU
After: https://share.firefox.dev/4bJCQb6

Fixes firefox-devtools#5915.

Before this fix, we were keeping the filtered-out stacks in the stack table.
Now we create a stack table which has those stacks removed.
A smaller stack table makes all the follow-on work faster.

Before: https://share.firefox.dev/4bXlszU
After: https://share.firefox.dev/4bJCQb6
@mstange mstange requested a review from canova March 26, 2026 19:24
@mstange mstange self-assigned this Mar 26, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.42%. Comparing base (f3f07c7) to head (d199335).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5916   +/-   ##
=======================================
  Coverage   85.41%   85.42%           
=======================================
  Files         321      321           
  Lines       32157    32161    +4     
  Branches     8865     8780   -85     
=======================================
+ Hits        27468    27472    +4     
  Misses       4253     4253           
  Partials      436      436           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switching to "All frames" is very slow in this profile (half the time spent in restoreAllFunctionsInCallPath)

1 participant