Skip to content

Refactor build caching for edge and stable + Update to v5.112.0 #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pascalandy wants to merge 7 commits into from
Closed

Refactor build caching for edge and stable + Update to v5.112.0 #595

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ef0448c
Update ghostfire to version 5.112.0
pascalandy Jun 9, 2025
f610b6a
Refactor Docker build caching between edge and stable
pascalandy Jun 9, 2025
1c22cbe
Fix: Correct path for docker-entrypoint.sh in Dockerfile
pascalandy Jun 9, 2025
bb03285
Fix: Optimize Docker build cache in GhostV5 workflow
pascalandy Jun 9, 2025
04dd18c
Update ghostfire to version 5.113.0
pascalandy Jun 9, 2025
e5e74e7
Refactor: Improve Docker build cache strategy
pascalandy Jun 9, 2025
35ea69f
Fix: Remove deprecated BUILDKIT_INLINE_CACHE from workflows
pascalandy Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

APP_NAME="ghostfire"
GITHUB_USER="firepress-org"
APP_VERSION="5.111.0"
APP_VERSION="5.112.0"

### function options
CFG_USE_GPG_SIGNATURE="false"
Expand Down
18 changes: 12 additions & 6 deletions .github/workflows/ghostv5.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ jobs:
- name: Build and push image (edge)
uses: docker/build-push-action@v6
with:
context: .
context: ./${{ env.SUB_DIR }}
file: ./${{ env.SUB_DIR }}/Dockerfile
platforms: |
linux/amd64
Expand All @@ -197,10 +197,13 @@ jobs:
${{ needs.myvars.outputs.TAG_DKR_BRANCH_NAME }}
${{ needs.myvars.outputs.TAG_GPR_BRANCH_NAME }}
# The order for <docker push -tag> matters for our CD down the line
cache-from: type=gha, scope=${{ github.workflow }}
cache-to: type=gha, scope=${{ github.workflow }}, mode=max
cache-from: |
type=gha,scope=${{ github.workflow }}-edge
type=gha,scope=${{ github.workflow }}-shared
cache-to: type=gha,scope=${{ github.workflow }}-edge,mode=max
build-args: |
BUILDKIT_PROGRESS=plain
BUILDKIT_INLINE_CACHE=1
network: host

- name: UAT run edge | Wait for container to run
Expand Down Expand Up @@ -270,7 +273,7 @@ jobs:
- name: Build and push image (stable)
uses: docker/build-push-action@v6
with:
context: .
context: ./${{ env.SUB_DIR }}
file: ./${{ env.SUB_DIR }}/Dockerfile
platforms: |
linux/amd64
Expand All @@ -288,10 +291,13 @@ jobs:
${{ needs.myvars.outputs.TAG_GPR_VERSION_HASH_ONLY }}
${{ needs.myvars.outputs.TAG_GPR_VERSION_HASH_DATE }}
# The order for <docker push -tag> matters for our CD down the line
cache-from: type=gha, scope=${{ github.workflow }}
cache-to: type=gha, scope=${{ github.workflow }}, mode=max
cache-from: |
type=gha,scope=${{ github.workflow }}-stable
type=gha,scope=${{ github.workflow }}-edge
cache-to: type=gha,scope=${{ github.workflow }}-stable,mode=max
build-args: |
BUILDKIT_PROGRESS=plain
BUILDKIT_INLINE_CACHE=1
network: host

- name: UAT run stable | Wait for container to run
Expand Down
4 changes: 2 additions & 2 deletions v5/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# 1a) ENV variables (core for all our projects at FirePress)
# ----------------------------------------------
ARG APP_NAME="ghostfire"
ARG VERSION="5.111.0"
ARG VERSION="5.112.0"

ARG GITHUB_USER="firepress-org"
ARG DEFAULT_BRANCH="master"
Expand Down Expand Up @@ -40,7 +40,7 @@
VERSION="${VERSION}" \
GHOST_CLI_VERSION="${GHOST_CLI_VERSION}"

LABEL org.opencontainers.image.authors="Pascal Andy https://firepress.org/en/contact/" \

Check warning on line 43 in v5/Dockerfile

View workflow job for this annotation

GitHub Actions / build_edge

Variables should be defined before their use 

UndefinedVar: Usage of undefined variable '$BASE_OS'
More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/

Check warning on line 43 in v5/Dockerfile

View workflow job for this annotation

GitHub Actions / build_edge

Variables should be defined before their use 

UndefinedVar: Usage of undefined variable '$VCS_REF'
More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/

Check warning on line 43 in v5/Dockerfile

View workflow job for this annotation

GitHub Actions / build_edge

Variables should be defined before their use 

UndefinedVar: Usage of undefined variable '$BUILD_DATE'
More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/
org.opencontainers.image.vendor="https://firepress.org/" \
org.opencontainers.image.created="${BUILD_DATE}" \
org.opencontainers.image.revision="${VCS_REF}" \
Expand All @@ -57,7 +57,7 @@
com.firepress.image.schema_version="1.0"

# Install gosu for easy step-down from root
ENV GOSU_VERSION 1.17

Check warning on line 60 in v5/Dockerfile

View workflow job for this annotation

GitHub Actions / build_edge

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
RUN set -eux; \
apk add --no-cache --virtual .gosu-deps \
ca-certificates \
Expand Down Expand Up @@ -187,7 +187,7 @@
# ----------------------------------------------
FROM mynode AS final

COPY --chown="${USER}":"${USER}" /v5/docker-entrypoint.sh /usr/local/bin
COPY --chown="${USER}":"${USER}" ./docker-entrypoint.sh /usr/local/bin
COPY --from=builder --chown="${USER}":"${USER}" "${GHOST_INSTALL}" "${GHOST_INSTALL}"

WORKDIR "${GHOST_INSTALL}"
Expand Down