Skip to content

Update ghostfire to version 5.123.0 #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pascalandy merged 1 commit into from
Jun 20, 2025
Merged

Update ghostfire to version 5.123.0 #604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

APP_NAME="ghostfire"
GITHUB_USER="firepress-org"
APP_VERSION="5.121.0"
APP_VERSION="5.123.0"
Copy link

@coderabbitai coderabbitai bot Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Consider removing unnecessary quotes and ordering the key.

The dotenv-linter flags the quotes in APP_VERSION="5.123.0" as unnecessary; you can simplify to:

APP_VERSION=5.123.0

Additionally, if you’re aiming for alphabetical key order in the file, you could place APP_VERSION immediately after APP_NAME.

🧰 Tools
🪛 dotenv-linter (3.3.0)

[warning] 6-6: [QuoteCharacter] The value has quote characters (', ")

[warning] 6-6: [UnorderedKey] The APP_VERSION key should go before the GITHUB_USER key

🤖 Prompt for AI Agents 
In the .env file at line 6, remove the unnecessary quotes around the APP_VERSION
value by changing APP_VERSION="5.123.0" to APP_VERSION=5.123.0. Also, reorder
the keys to place APP_VERSION immediately after APP_NAME to maintain
alphabetical order.


### function options
CFG_USE_GPG_SIGNATURE="false"
Expand Down
2 changes: 1 addition & 1 deletion v5/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# 1a) ENV variables (core for all our projects at FirePress)
# ----------------------------------------------
ARG APP_NAME="ghostfire"
ARG VERSION="5.121.0"
ARG VERSION="5.123.0"

ARG GITHUB_USER="firepress-org"
ARG DEFAULT_BRANCH="master"
Expand Down Expand Up @@ -40,7 +40,7 @@
VERSION="${VERSION}" \
GHOST_CLI_VERSION="${GHOST_CLI_VERSION}"

LABEL org.opencontainers.image.authors="Pascal Andy https://firepress.org/en/contact/" \

Check warning on line 43 in v5/Dockerfile

View workflow job for this annotation

GitHub Actions / build_edge

Variables should be defined before their use 

UndefinedVar: Usage of undefined variable '$BASE_OS'
More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/

Check warning on line 43 in v5/Dockerfile

View workflow job for this annotation

GitHub Actions / build_edge

Variables should be defined before their use 

UndefinedVar: Usage of undefined variable '$VCS_REF'
More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/

Check warning on line 43 in v5/Dockerfile

View workflow job for this annotation

GitHub Actions / build_edge

Variables should be defined before their use 

UndefinedVar: Usage of undefined variable '$BUILD_DATE'
More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/
org.opencontainers.image.vendor="https://firepress.org/" \
org.opencontainers.image.created="${BUILD_DATE}" \
org.opencontainers.image.revision="${VCS_REF}" \
Expand All @@ -57,7 +57,7 @@
com.firepress.image.schema_version="1.0"

# Install gosu for easy step-down from root
ENV GOSU_VERSION 1.17

Check warning on line 60 in v5/Dockerfile

View workflow job for this annotation

GitHub Actions / build_edge

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
RUN set -eux; \
apk add --no-cache --virtual .gosu-deps \
ca-certificates \
Expand Down