Drive updates/fixes#373
Open
BenraouaneSoufiane wants to merge 11 commits intofireproof-storage:mabels/gdrivefrom
Open
Drive updates/fixes#373BenraouaneSoufiane wants to merge 11 commits intofireproof-storage:mabels/gdrivefrom
BenraouaneSoufiane wants to merge 11 commits intofireproof-storage:mabels/gdrivefrom
Conversation
mabels
reviewed
Mar 18, 2025
src/drive/drive-gateway.ts
Outdated
| }; | ||
| try { | ||
| const response = await fetch(url + fileId, { | ||
| const response = await fetch(BuildURI.from(url).appendRelative('drive/v3/files') + fileId, { |
Contributor
There was a problem hiding this comment.
appendRelative('x').appendRelative('y')
mabels
reviewed
Mar 18, 2025
src/drive/drive-gateway.ts
Outdated
| headers = { | ||
| Authorization: `Bearer ${auth}`, | ||
| }; | ||
| response = await fetch(url.appendRelative(`drive/v3/files/${fileId}`).setParam("alt", "media").toString(), { |
Contributor
There was a problem hiding this comment.
better but you can chain .appendRelative
mabels
reviewed
Mar 18, 2025
src/drive/drive-gateway.ts
Outdated
| fileData: Blob, | ||
| auth: string, | ||
| store: "data" | "wal" | "meta" | ||
| store: string |
Contributor
There was a problem hiding this comment.
leave it strongly typed.
there might needed a small helper like:
function toStore(s: string): "data" | "wal" | "meta" {
if (["data", "wal", "meta"].include(s)) { return s as "data"|"wal"|"meta" }
throw new Error(unknown Store:${s})
}
mabels
reviewed
Mar 18, 2025
src/drive/drive-gateway.ts
Outdated
| } | ||
| } | ||
| async #search(fileName: string, auth: string): Promise<Result<string>> { | ||
| async #search(fileName: string, auth: string, store: string): Promise<Result<string>> { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.