Spark

[jacobrosenthal]

Spark.io support

[blakejakopovic]

I'd like to see Spark Core support also. 👍 Thanks @jacobrosenthal

[rwaldron]

This won't work as it does with the other boards defined in this file. The Spark's PWM support is available on D0, D1, A0, A1, A4, A5, A6 and A7.

[soundanalogous]

it will work as long as the spark core firmware defines digitalPinHasPWM

[jacobrosenthal]

How about

#define IS_PIN_PWM(p)           ((p) == 0 || (p) == 1 || ((p) >= 10 && (p) <= 17))

[soundanalogous]

Ideally the equivalent of an arduino variant pins_arduino.h file should be added to spark/core-firmware. Here's an example from the standard arduino variant: https://github.com/arduino/Arduino/blob/master/hardware/arduino/variants/standard/pins_arduino.h

[soundanalogous]

Is there a spark core port to Arduino?

[soundanalogous]

What is the reasoning behind this change?

[jacobrosenthal]

Spark (and maybe others) don't support any random positive number as a truth value. @rwaldron is attempting to push a fix upstream https://github.com/spark/core-firmware/issues/247 so it may not be necessary

[soundanalogous]

This pull request needs to be submitted against the dev branch, not master. I don't accept pull requests to master unless it's just a readme update or something like that.

[jacobrosenthal]

What to do with this mess now.

I can revert the bitmask lines, but we seem no closer to an agreed upon Spark #ifdef

Another issue Ive found is Spark has swapped their input/output enum

https://github.com/spark/core-firmware/issues/282

[soundanalogous]

The best solution is if Spark implements the Arduino Stream interface. This would be a smart move for them in terms of Arduino compatibility. That would eliminate the need for the Spark #ifndef in Firmata.cpp if I update Firmata.cpp to include Stream.h rather than HardwareSerial.h.

[jacobrosenthal]

Seems like they do:

https://github.com/spark/core-firmware/blob/9b01d795ecaaf657399dc4888f30f3898d91d74a/inc/spark_wiring_stream.h

heres it being used

https://github.com/spark/core-firmware/blob/9b01d795ecaaf657399dc4888f30f3898d91d74a/inc/spark_wiring_usbserial.h

On Mon, Sep 1, 2014 at 7:54 PM, Jeff Hoefs [email protected] wrote:

compatibility. That would eliminate the need for the Spark #ifndef in
Firmata.cpp if I update Firmata.cpp to include Stream.h rather than

[soundanalogous]

If I merge this: #144

It will eliminate the need for any reference to Spark in Firmata.cpp. However it's going to break pretty much everything anyone has made with Firmata that relies on HardwareSerial so I'm not sure when is a good time to release it.

[jacobrosenthal]

That seems like a admirable goal, but in the meantime Id love to get the
define for now.

I dont think I need the digital write change anymore since it was accepted
upstream.

Im testing the rest of the Boards entry to make sure its good for stuff
other than digital write and read.

Ill submit against dev soon.

On Mon, Sep 1, 2014 at 8:14 PM, Jeff Hoefs [email protected] wrote:

ase it.

[soundanalogous]

For now, I would rather create a separate version of Firmata for Spark firmata/spark than make exceptions for the Arduino version of Firmata to conform with Spark. Once Spark is fully arduino compatible (like a Teensy is for example) then it will be a non issue just to use the firmata/arduino repo for Spark boards.

[soundanalogous]

https://github.com/firmata/spark

[jacobrosenthal]

We're over at https://github.com/firmata/spark now. Thanks all.