replace error strings with error codes #176
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Closing this since it is not likely to be the implementation. Still planning to revisit for Firmata 3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update frees 122 bytes of RAM. I have replace the old string error messages in StandardFirmata with single byte error codes (0 - 127). A user can add custom error codes to any Firmata sketch. The client library should provide a message for each error code (or otherwise handle the error as necessary).
This update may impact any client library that handles the old string error messages sent by StandardFirmata (if this is actually the case with any client library - I suspect it is rare). However, given that this pull request is for Firmata 2.4.0 and the RAM savings and overall more explicit nature of the new error_code I think this update justifies the backwards incompatible change.
See conversation here: #80