Make db txs atomic, use Decimals instead of Floats, and replace prints with logs#3
Draft
sneurlax wants to merge 3 commits intofiroorg:masterfrom
Draft
Make db txs atomic, use Decimals instead of Floats, and replace prints with logs#3sneurlax wants to merge 3 commits intofiroorg:masterfrom
sneurlax wants to merge 3 commits intofiroorg:masterfrom
Conversation
sneurlax
commented
Aug 26, 2024
- Make database transactions atomic to avoid race conditions related to balance updates.
- Use Decimals vs. Floats to avoid imprecise balance calculations.
- Replace prints with proper logging to save errors & info messages for later analysis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.