Исправил ошибку сборки EDT 2024+

[ovcharenko-di]

Ошибка воспроизводится при сборке EDT 2024+.

В случае отсутствия файла ring-commands.cfg команда COPY --from=installer /etc/1C/1CE/ring-commands.cfg /etc/1C/1CE/ring-commands.cfg выдает ошибку.

Я сделал так, чтобы файл всегда присутствовал.

Summary by CodeRabbit

• Bug Fixes

  • Prevented build failures by safely handling missing ring commands configuration during installation.
  • Ensured consistent Russian locale settings across build stages for more predictable runtime behavior.

• Chores

  • Standardized environment variable declarations in the Docker build for clarity and compatibility.
  • Extended temporary file cleanup to reduce image clutter and improve build hygiene.

[coderabbitai]

Walkthrough

Converted locale ENV declarations in edt/Dockerfile to key=value syntax in both stages. Added a guard to create /etc/1C/1CE/ring-commands.cfg if missing and extended cleanup of /tmp/* accordingly within two RUN steps.

Changes

Cohort / File(s)	Summary of changes
Locale ENV normalization edt/Dockerfile	Changed ENV LANG, ENV LANGUAGE, ENV LC_ALL from space-separated to key=value form in two stages.
Ring commands config guard edt/Dockerfile	Added touch /etc/1C/1CE/ring-commands.cfg in relevant RUN blocks to ensure file exists.
Build cleanup adjustments edt/Dockerfile	Extended /tmp/* cleanup lines in two RUN steps to include the new guard path handling.

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Исправлена сборка образа EDT, когда внутри нужно использовать ring #71 — Also handles /etc/1C/1CE/ring-commands.cfg, adding copy/symlink logic alongside ensuring presence.
• Бампнул версию джавы для агента оскрипта и добавил локаль в образ edt #57 — Introduced the locale ENV variables that this PR now normalizes to key=value form.
• Уменьшил размер образа EDT в 2 раза #68 — Touches the same locale ENV declarations and Dockerfile cleanup steps in edt/Dockerfile.

Poem

I hopped through layers, tidy and keen,
Set LANG and friends to equals-been,
A gentle tap—ring commands appear,
No missing file to cause us fear.
Sweep the /tmp, make build paths clean—
Ship it fresh, in rabbit sheen. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "Исправил ошибку сборки EDT 2024+" succinctly and accurately summarizes the primary change—fixing the EDT 2024+ build error—and it directly matches the PR objective and the Dockerfile changes that ensure ring-commands.cfg exists to prevent the COPY failure. It is concise, specific, and readable for repository history. The phrasing clearly communicates the main intent of the changeset.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

edt/Dockerfile (2)

35-37: Good switch to key=value form for ENV.

Consistent and idiomatic. Optionally, collapse into a single ENV to reduce layers.

Apply this minimal tidy-up:

-ENV LANG=ru_RU.UTF-8
-ENV LANGUAGE=ru_RU:ru
-ENV LC_ALL=ru_RU.UTF-8
+ENV LANG=ru_RU.UTF-8 LANGUAGE=ru_RU:ru LC_ALL=ru_RU.UTF-8

---

98-100: Same ENV style improvement as above.

Consider consolidating into one ENV for a cleaner layer history.

-ENV LANG=ru_RU.UTF-8
-ENV LANGUAGE=ru_RU:ru
-ENV LC_ALL=ru_RU.UTF-8
+ENV LANG=ru_RU.UTF-8 LANGUAGE=ru_RU:ru LC_ALL=ru_RU.UTF-8

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 61f0370 and ec0c2d4.

📒 Files selected for processing (1)

• edt/Dockerfile (3 hunks)

[coderabbitai]

⚠️ Potential issue

Ensure parent directory exists before touch; fix typo in comment.

If /etc/1C/1CE doesn’t exist in some EDT versions, touch will fail and break the build. Create the directory first. Also correct “следуюших” → “следующих”.

Apply:

-    /tmp/* \
-  # создадим пустой файл, чтобы не было ошибок на следуюших этапах в случае его отсутствия
-  && if [ ! -f /etc/1C/1CE/ring-commands.cfg ]; then touch /etc/1C/1CE/ring-commands.cfg; fi
+    /tmp/* \
+  # создадим пустой файл, чтобы не было ошибок на следующих этапах в случае его отсутствия
+  && mkdir -p /etc/1C/1CE \
+  && if [ ! -f /etc/1C/1CE/ring-commands.cfg ]; then touch /etc/1C/1CE/ring-commands.cfg; fi

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	/tmp/* \
	# создадим пустой файл, чтобы не было ошибок на следуюших этапах в случае его отсутствия
	&& if [ ! -f /etc/1C/1CE/ring-commands.cfg ]; then touch /etc/1C/1CE/ring-commands.cfg; fi
	/tmp/* \
	# создадим пустой файл, чтобы не было ошибок на следующих этапах в случае его отсутствия
	&& mkdir -p /etc/1C/1CE \
	&& if [ ! -f /etc/1C/1CE/ring-commands.cfg ]; then touch /etc/1C/1CE/ring-commands.cfg; fi

🤖 Prompt for AI Agents

In edt/Dockerfile around lines 74 to 76, the script touches
/etc/1C/1CE/ring-commands.cfg without ensuring its parent directory exists and
the comment contains a typo; update the Dockerfile to first create the directory
if missing (e.g., mkdir -p /etc/1C/1CE) before touching the file, and correct
the comment word “следуюших” to “следующих”.