Skip to content

bugfix + version changed! #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iX315 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

bugfix + version changed! #7

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d9e7ba
version fix
iX315 Apr 16, 2017
ee63855
bugfix
iX315 Apr 16, 2017
8628211
rollback
iX315 Apr 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,9 @@ var combo = function(a, min, max) {
return;
}
var all = [];
for (var i = min; i < a.length; i++) {
for (var i = min; i <= max; i++) {
fn(i, a, [], all);
}
if(a.length == max) all.push(a);
return all;
}
module.exports = combo;
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "combinations",
"version": "0.1.1",
Copy link
Member

@jgallen23 jgallen23 Apr 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json changes when we do a release, can you remove this change?

Copy link
Contributor Author

@iX315 iX315 Apr 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the version as NPM don't check the changes...
DOCS

"version": "0.1.3",
"description": "find all combinations from array",
"main": "index.js",
"repository": {
Expand Down
6 changes: 6 additions & 0 deletions test/combo.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,11 @@ suite('combo', function() {
assert.deepEqual(out, [ [ 'a', 'b' ], [ 'a', 'c' ], [ 'a', 'd'], [ 'b', 'c' ], [ 'b', 'd'], [ 'c', 'd' ], [ 'a', 'b', 'c' ], [ 'a', 'b', 'd' ], [ 'a', 'c', 'd' ], [ 'b', 'c', 'd' ] ]);
});

test('4 item array with min 3 and max 3 elements', function() {
var out = combo(['a', 'b', 'c', 'd'],3,3);

assert.deepEqual(out, [ [ 'a', 'b', 'c' ], [ 'a', 'b', 'd' ], [ 'a', 'c', 'd' ], [ 'b', 'c', 'd' ] ]);
});

});