-
Notifications
You must be signed in to change notification settings - Fork 1
V4 #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Psiale
wants to merge
45
commits into
v3
Choose a base branch
from
v4
base: v3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
V4 #37
Changes from 27 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
d7c0798
updating readme
Psiale eb1f6b0
working on G4 updates
Psiale 80be535
added sendEventG4
Psiale 80e631f
created sendEventG4
Psiale 2455598
changed README
Psiale 9736ceb
fixed readme
Psiale 4555ddb
workin on example
Psiale fdd2326
adding example
Psiale dbb2a98
handling error
Psiale 4a0ffaf
handling error
Psiale 3db9b49
handling error
Psiale b19b96a
error handling
Psiale 5bec458
solved error
Psiale 2d0c902
console log args"
Psiale 81676a9
debugging
Psiale 217b1be
debugging
Psiale 571e30b
debugging
Psiale c784013
debugging
Psiale 1ce074e
debugging
Psiale 834364e
debugging
Psiale a43f8ab
adding client_id
Psiale cbcb6ea
using gtag method)
Psiale 8944ea5
removing unnecesary check for GTAg
Psiale 068c923
working
Psiale b35ebf9
working this out
Psiale a9ab204
working this out
Psiale 4a8c240
changed sendEvent method to also use V4
Psiale 76626e6
Update README.md
Psiale a982b21
done with requested changes
Psiale b0d92e0
Merge branch 'v4' of github.com:firstandthird/ga-track into v4
Psiale d4a6a37
working on GA using dataLayer
Psiale 6a00989
working on GA using dataLayer
Psiale 0186efd
working on GA using dataLayer
Psiale 77c90dd
working on GA using dataLayer
Psiale 1d8b387
working on GA using dataLayer
Psiale 7496b1d
working on GA using dataLayer
Psiale 87ea009
working on GA using dataLayer
Psiale af11a59
working on GA using dataLayer
Psiale 2fe291f
working on GA using dataLayer
Psiale dfa7e73
working on GA using dataLayer
Psiale e6eb5b3
working on GA using dataLayer
Psiale 097ca19
changing object structure
Psiale 779cb9e
changed sendEvent and created new function
Psiale 19744a5
adding ga-track
Psiale eac406e
solving conflicts
Psiale File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| <!DOCTYPE html> | ||
| <html> | ||
| <head> | ||
| <title></title> | ||
| <!-- Global site tag (gtag.js) - Google Analytics --> | ||
| <script async src="https://www.googletagmanager.com/gtag/js?id=GA_MEASUREMENT_ID"></script> | ||
| <script> | ||
| window.dataLayer = window.dataLayer || []; | ||
| function gtag(){window.dataLayer.push(arguments);} | ||
| gtag('js', new Date()); | ||
|
|
||
| gtag('config', ' G-88YEW4V4VV'); | ||
Psiale marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| </script> | ||
| </head> | ||
| <body> | ||
| <button onclick="test()">Click me to run test</button> | ||
| <script src="index.js"> | ||
| GaTrack.V4 = true; | ||
| const test = () => GaTrack.sendEventV4('test', [{test_param_1: 'test value 1'}, {test_param_2: 'test value 2'}]) | ||
| </script> | ||
| </body> | ||
| </html> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.