Skip to content

Bump response limit #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nilsding wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bump response limit #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/hcaptcha.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

module Hcaptcha
DEFAULT_TIMEOUT = 3
RESPONSE_LIMIT = 4000
RESPONSE_LIMIT = 32767

class HcaptchaError < StandardError
end
Expand Down
11 changes: 6 additions & 5 deletions test/verify_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,17 +167,18 @@

it "does not verify via http call when user did not click anything" do
@controller.params = { 'h-captcha-response' => ""}
assert_not_requested :get, %r{\.google\.com}
assert_not_requested :get, %r{\.hcaptcha\.com}
assert_equal false, @controller.verify_hcaptcha
assert_equal "hCaptcha verification failed, please try again.", @controller.flash[:hcaptcha_error]
end

it "does not verify via http call when response length exceeds G_RESPONSE_LIMIT" do
it "does not verify via http call when response length exceeds RESPONSE_LIMIT" do
# this returns a 400 or 413 instead of a 200 response with error code
# typical response length is less than 400 characters
str = "a" * 4001
# typical response length seems to be around 4000 characters, can be slightly above that though.
# This fork bumps the limit to 32767 characters. Should be more than enough.
str = "a" * 32768
@controller.params = { 'h-captcha-response' => "#{str}"}
assert_not_requested :get, %r{\.google\.com}
assert_not_requested :get, %r{\.hcaptcha\.com}
assert_equal false, @controller.verify_hcaptcha
assert_equal "hCaptcha verification failed, please try again.", @controller.flash[:hcaptcha_error]
end
Expand Down