Skip to content

chore: reduce python version matrix in CI configuration #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
twangodev wants to merge 1 commit into from
+1 −1
Closed

chore: reduce python version matrix in CI configuration #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/python.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13", "3"]
python-version: ["3.9", "3"]
Copy link

@coderabbitai coderabbitai bot Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash

# Check for package metadata files
echo "=== Checking for package metadata files ==="
ls -la pyproject.toml setup.py setup.cfg 2>/dev/null | grep -E "pyproject.toml|setup.py|setup.cfg" || echo "No standard metadata found in root"

# Check pyproject.toml for python version requirements
if [ -f "pyproject.toml" ]; then
  echo ""
  echo "=== pyproject.toml (full content) ==="
  cat pyproject.toml
fi

# Check setup.py if it exists
if [ -f "setup.py" ]; then
  echo ""
  echo "=== setup.py ==="
  head -100 setup.py
fi

# Check setup.cfg if it exists
if [ -f "setup.cfg" ]; then
  echo ""
  echo "=== setup.cfg ==="
  cat setup.cfg
fi

Repository: fishaudio/fish-audio-python

Length of output: 2967

Reduce untested Python version gap or update package compatibility declarations.

The package declares support for Python 3.9, 3.10, 3.11, 3.12, 3.13, and 3.14 in pyproject.toml, but the CI matrix change to ["3.9", "3"] eliminates testing for 3.10–3.13. This creates a mismatch between declared support and tested versions, risking undetected version-specific issues in actively supported releases.

Either expand the test matrix to include at least 3.10 and 3.12 (or all intermediate versions), or update the classifiers in pyproject.toml to reflect the actual supported versions.

🤖 Prompt for AI Agents 
In @.github/workflows/python.yml at line 43, The CI matrix change altered the
python-version entry ("python-version") from explicit versions to ["3.9","3"],
which removes testing for 3.10–3.13 and now conflicts with the Python versions
listed in pyproject.toml classifiers; either update the workflow's
python-version array to include the missing versions (e.g., add "3.10" and
"3.12" or all supported minors) so tests cover declared versions, or edit the
Python classifiers in pyproject.toml to match the reduced/tested set—make the
change in the GitHub Actions workflow's python-version key or in the
pyproject.toml classifiers accordingly.

steps:
- uses: actions/checkout@v5
- name: Install uv
Expand Down