Skip to content

Cleanup the game even if deleting the peer fails #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AHGIJMKLKKZNPJKQR merged 3 commits into from
Jan 26, 2026
Merged

Cleanup the game even if deleting the peer fails #46

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e548149
Cleanup the game even if deleting the peer fails
AHGIJMKLKKZNPJKQR Jan 26, 2026
7d0a3e2
Make it more clear that gameSession is always null after stopping
AHGIJMKLKKZNPJKQR Jan 26, 2026
d960e71
Improve error handling and toasts
AHGIJMKLKKZNPJKQR Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions deep-sea-stories/packages/backend/src/game/room.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,28 +200,28 @@ export class GameRoom {
this.gameTimeoutId = null;
}

if (this.gameSession) {
await this.gameSession.stopGame(wait);
try {
try {
if (this.gameSession) {
await this.gameSession.stopGame(wait);
await this.fishjamClient.deletePeer(
this.roomId,
this.gameSession.agentId,
);
this.gameSession = null;
} catch (e) {
if (!(e instanceof PeerNotFoundException)) throw e;
}
} catch (e) {
if (!(e instanceof PeerNotFoundException)) throw e;
} finally {
this.gameSession = null;
this.story = undefined;

this.notifierService.emitNotification(this.roomId, {
type: 'gameEnded' as const,
timestamp: Date.now(),
});

this.gameStarted = false;
console.log(`Stopped game for room ${this.roomId}`);
}

this.story = undefined;

this.notifierService.emitNotification(this.roomId, {
type: 'gameEnded' as const,
timestamp: Date.now(),
});

this.gameStarted = false;
console.log(`Stopped game for room ${this.roomId}`);
}

private async createFishjamAgent() {
Expand Down