Skip to content

display only webrtc peer tiles, ensure copied link works#9

Merged
Gawor270 merged 5 commits intomainfrom
dont-display-agents
Oct 23, 2025
Merged

display only webrtc peer tiles, ensure copied link works#9
Gawor270 merged 5 commits intomainfrom
dont-display-agents

Conversation

@Gawor270
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings October 23, 2025 13:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the GameView component to filter out agent peers from the displayed video tiles while maintaining separate audio playback for the agent. The changes ensure that only WebRTC peer tiles (non-agent participants) are displayed in the video grid, while the agent's audio stream is played through a separate hidden audio element.

Key Changes:

  • Filters agent peers from the displayed peer tiles based on peer type
  • Adds separate audio element for agent audio playback
  • Updates grid layout calculation to reflect only displayed peers
Comments suppressed due to low confidence (1)

deep-sea-stories/packages/web/src/views/GameView.tsx:1

  • The useEffect dependency uses 'agentPeer?.tracks[0]?.stream' but the effect body uses 'agentPeer?.tracks[0]?.stream'. The dependency should be 'agentPeer?.tracks[0]?.stream' instead of 'agentPeer?.microphoneTrack?.stream' to match the actual value being used in line 49, or line 49 should use microphoneTrack to match the dependency.
import { usePeers } from '@fishjam-cloud/react-client';

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Gawor270 Gawor270 changed the title display only webrtc peer tiles display only webrtc peer tiles, ensure copied link works Oct 23, 2025
@Gawor270 Gawor270 merged commit f7ceab6 into main Oct 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants