Skip to content

show deprecation warning#226

Merged
Gawor270 merged 3 commits intomainfrom
FCE-2653
Jan 28, 2026
Merged

show deprecation warning#226
Gawor270 merged 3 commits intomainfrom
FCE-2653

Conversation

@Gawor270
Copy link
Member

@Gawor270 Gawor270 commented Jan 26, 2026

Description

Describe your changes.

Motivation and Context

Why is this change required? What problem does it solve? If it fixes an open
issue, please link to the issue here.

Documentation impact

  • Documentation update required
  • Documentation updated in another PR
  • No documentation update required

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)

@linear
Copy link

linear bot commented Jan 26, 2026

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds client-side handling for a deprecation header returned by the Fishjam API, logging a deprecation or unsupported warning once per FishjamClient instance.

Changes:

  • Extend the Axios client setup in FishjamClient with a response interceptor that inspects the x-fishjam-api-deprecated response header.
  • Add handleDeprecationHeader to parse deprecation metadata from the header and log either console.error or console.warn based on the reported status, ensuring the warning is only shown once per client instance.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Gawor270 Gawor270 merged commit 7aa9127 into main Jan 28, 2026
1 check passed
@Gawor270 Gawor270 deleted the FCE-2653 branch January 28, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants