Merged
Conversation
| @@ -1,3 +1,4 @@ | |||
| {{ salesforce_formula_utils.sfdc_formula_view( | |||
| source_table = 'account', | |||
| using_quoted_identifiers = var('using_quoted_identifiers', false), | |||
Contributor
Author
There was a problem hiding this comment.
Wanted a way to test this.
Comment on lines
+23
to
+28
| {%- set run_query %} | ||
| select 'has_values' | ||
| from {{ source(source_name, 'fivetran_formula_model') }} | ||
| where model_large is not null | ||
| limit 1 | ||
| {%- endset %} |
Contributor
Author
There was a problem hiding this comment.
I figured this was the least expensive query to check for non-null values since we don't have to scan the entire table, but open to suggestions.
fivetran-joemarkiewicz
approved these changes
Feb 19, 2026
Collaborator
fivetran-joemarkiewicz
left a comment
fivetran-joemarkiewicz
left a comment
There was a problem hiding this comment.
LGTM with one CHANGELOG suggestion
CHANGELOG.md
Outdated
| [PR #129](https://github.com/fivetran/dbt_salesforce_formula_utils/pull/129) includes the following updates: | ||
|
|
||
| ## Feature Update | ||
| - Adds support for Redshift's `SUPER` data type in the `sfdc_formula_view` macro, enabling proper handling of large model configurations stored as JSON in the `fivetran_formula_model.model_large` column. |
Collaborator
There was a problem hiding this comment.
You mention it, but let's make this explicit that this entire feature update is only applicable to Redshift destinations.
fivetran-catfritz
added
docs:ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
Summary of changes:
SUPERdata type in thesfdc_formula_viewmacro, enabling proper handling of large model configurations stored as JSON in thefivetran_formula_model.model_largecolumn.Submission Checklist
Changelog