Allow response generation with no user message#310
Merged
zqhuang211 merged 1 commit intofixie-ai:mainfrom Aug 5, 2025
Merged
Conversation
zqhuang211
approved these changes
Aug 1, 2025
Contributor
zqhuang211
left a comment
zqhuang211
left a comment
There was a problem hiding this comment.
It looks good. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I may be wrong, but it is currently not possible to generate an assistant message without first inputting a user message. This would allow for situations where you might want to generate an assistant message with just a system message prompt. This PR allows for
sampleto beNone, provided there are previous messages in the history (such as system messages). I am not sure if this is the best implementation - so please let me know if it needs any changes!