Conversation
|
I don't think this will work together with how we generate a random transformation: |
|
Sorry for the delay, hope its fine now. |
|
It seems fine. Did you test it somehow to make sure the results were reproduced over two runs? |
|
I'm not sure if this can work correctly with multithreaded workers running the generator. If variation in processing time changes the way work is distributed over threads, that would affect the random transforms. With a single worker it should be fine I think. Might be worth adding a warning if multiple workers are used together with a seed. |
@martinzlocha what do you think? |
|
@hgaiser Yes I completely agree with the multi worker issue. Unfortunately I don't have the time right now to write proper tests and not sure when I will come back to this so it might be best to close the PR if its not a requested feature. |
As we briefly discussed in #1075 I am adding the possibility to provide seed values.