Skip to content

feat: allow multiple credentials for input connector#938

Open
Pablu23 wants to merge 8 commits intomainfrom
feat-multiple-credentials
Open

feat: allow multiple credentials for input connector#938
Pablu23 wants to merge 8 commits intomainfrom
feat-multiple-credentials

Conversation

@Pablu23
Copy link
Collaborator

@Pablu23 Pablu23 commented Feb 20, 2026

Description

  • Briefly summarize your changes in a few bullet points (can and should correspond to CHANGELOG.md)
  • Relates to #XXX (insert issue number here), if there is a corresponding GH issue

Assignee

  • The changes adhere to the contribution guidelines
  • I have performed a self-review of my code
  • My changes generate no new warnings (e.g. flake8/mypy/pytest/...) other than deprecations

Documentation

Code Quality

  • Patch test coverage > 95% and does not decrease
  • New code uses correct & specific type hints

How did you verify that the changes work in practice?

  • List of (preferably easy reproducible) tests including OS

Reviewer


The rendered docs for this PR can be found here.

…too, improved checking for correct auth by time constant comparison and not, halt checking for is in
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.16%. Comparing base (62308c3) to head (fa5af82).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #938      +/-   ##
==========================================
+ Coverage   96.13%   96.16%   +0.02%     
==========================================
  Files         217      217              
  Lines       14220    14245      +25     
==========================================
+ Hits        13671    13698      +27     
+ Misses        549      547       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@kaya-david kaya-david left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left some comments

@Pablu23 Pablu23 marked this pull request as ready for review February 26, 2026 09:18
@Pablu23 Pablu23 self-assigned this Feb 26, 2026

if self._token.is_expired and self._token.refresh_token is not None:
if self._token and self._token.is_expired and self._token.refresh_token is not None:
session = Session()
Copy link
Collaborator

@mhoff mhoff Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This creates a fresh session without the super().get_session() semantics which ensure a retry behavior is configured. I would propose to refactor Credentials.get_session() to call a new method self._create_and_save_session(). This new method can then be re-used in this line to ensure a retry configuration is being set properly.

I propose to include setting self._session in this new method as well (in contrast to a pure self._create_session() method) because the management of this attribute is an internal aspect of the super class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants