feat: add benchmark.py + small logprep-ng adaptions#939
feat: add benchmark.py + small logprep-ng adaptions#939kaya-david wants to merge 5 commits intomainfrom
Conversation
|
@mhoff Feel free to take a look and try it out. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #939 +/- ##
=======================================
Coverage 96.14% 96.15%
=======================================
Files 217 217
Lines 14219 14219
=======================================
+ Hits 13671 13672 +1
+ Misses 548 547 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kaya-david
force-pushed
the
dev-logprep-ng-benchmark
branch
from
ef53aca to
dea212d
Compare
Pablu23
left a comment
Pablu23
left a comment
There was a problem hiding this comment.
LGTM, not as strict of a review because its a script for now, but a few points. Like we talked about, change or leave them how you see fit
kaya-david
force-pushed
the
dev-logprep-ng-benchmark
branch
from
f922ddb to
7c28b90
Compare
Pablu23
left a comment
Pablu23
left a comment
There was a problem hiding this comment.
Please remove old benchmark.sh as this is unneccessary now. Update PR Description and How you tested this, probably just a "run benchmark.py" see output. And after that this looks very good thank you for the work :)
| def opensearch_refresh(opensearch_url: str, processed_index: str) -> None: | ||
| """ | ||
| Force a refresh of the processed index so counts reflect recent writes. | ||
|
|
||
| Args: | ||
| opensearch_url: OpenSearch base URL. | ||
| processed_index: Index name to refresh. | ||
| """ | ||
| resp = requests.post(f"{opensearch_url}/{processed_index}/_refresh", timeout=10) | ||
| if resp.status_code == 404: | ||
| return | ||
| resp.raise_for_status() |
There was a problem hiding this comment.
Have you found this to be needed? If yes have you looked into the documentation of why that is? I understood the documentation, that this is for preloading in performance critical paths
4 participants
Description
Assignee
Documentation
Code Quality
How did you verify that the changes work in practice?
Reviewer
The rendered docs for this PR can be found here.