Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the way tokenization works during prediction. It is now possible for models to remember the specific tokenizer they were trained with. This allows us to ensure that when predicting tags, both the model and the sentence objects follow the same tokenization scheme. Theoretically, this should yield better prediction accuracy.
Specifically:
DefaultClassifier- if trained with a specific tokenizer - now set this tokenizer to any Sentence object that is passed to them during prediction. Same for the SequenceTagger.Sentenceobject now remembers the tokenization used to generateTokens. There is a new setter that allows setting a different tokenizer for an already created Sentence. If a different tokenizer is set and tokens are requested, this triggers a retokenization with the new tokenization scheme.Tokenizers are now serializable and have equality defined.Closes #3655