Add Media Indonesia Publisher #804
Conversation
vrdhn91
changed the title
addie9800
left a comment
addie9800
left a comment
There was a problem hiding this comment.
Thanks for adding our first Indonesian publisher! I do have a couple of comments, before we can continue with the next step.
|
|
||
|
|
||
| class MediaIndonesiaParser(ParserProxy): | ||
| class V1(BaseParser): |
There was a problem hiding this comment.
The images attribute seems to be missing
There was a problem hiding this comment.
topics also seem to be missing. They can be accessed using the meta attribute keywords.
|
|
||
| class MediaIndonesiaParser(ParserProxy): | ||
| class V1(BaseParser): | ||
| _paragraph_selector = CSSSelector("div.article") |
There was a problem hiding this comment.
This paragraph selector selects just the entire article as one big paragraph. You should consider something like div.article > p. Make sure it is consistent with the subheadlines of this article. I would recommend switching to XPaths, I personally prefert them for these more subtle cases.
| class MediaIndonesiaParser(ParserProxy): | ||
| class V1(BaseParser): | ||
| _paragraph_selector = CSSSelector("div.article") | ||
| _subheadline_selector = CSSSelector("div.article > h2") |
There was a problem hiding this comment.
This article uses a different formatting for the subheadlines.
2 participants
To add Media Indonesia publisher, a new python file is created (media_indonesia.py) for the parser class. Extracted information are title, author, published date, and article.