-
Notifications
You must be signed in to change notification settings - Fork 107
Add German publisher T-Online #805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
addie9800
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding T-Online. Unfortunately, it did not run on my device. I left a couple of comments pointing out the issues.
| domain="https://www.t-online.de/", | ||
| parser=TOnlineParser, | ||
| sources=[ | ||
| Sitemap("https://www.t-online.de/sitemap.xml"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Sitemap does not work. Use RSSFeeds from here instead: https://www.t-online.de/id_15610510/nachrichten-aus-aller-welt-dank-rss-feeds-von-t-online-de-immer-auf-dem-laufenden.html
|
|
||
|
|
||
| class TOnlineParser(ParserProxy): | ||
| class V1(BaseParser): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are missing the images and topics attributes.
|
|
||
| class TOnlineParser(ParserProxy): | ||
| class V1(BaseParser): | ||
| _paragraph_selector = CSSSelector("div[class*='px-24'] > p.text-18") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to rework all the selectors, they do not seem to work.
| ], | ||
| ) | ||
|
|
||
| TOnline = Publisher( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As soon as you're done implementing this parser, please follow these steps to generate the test files. Make sure that the test article includes, topics, images and subheadlines.
Implements the T-Online publisher with body content extraction.
Changes:
subheadings
The parser extracts: