Skip to content

fix: Hitboxes with vertically flipped ancestor should not reflect angle for vertices#3642

Merged
spydon merged 6 commits intomainfrom
fix/use-abs-scale-on-vertices
Jul 12, 2025
Merged

fix: Hitboxes with vertically flipped ancestor should not reflect angle for vertices#3642
spydon merged 6 commits intomainfrom
fix/use-abs-scale-on-vertices

Conversation

@spydon
Copy link
Member

@spydon spydon commented Jul 12, 2025

Description

We broke vertically flipped hitboxes in #3629, this fixes it up so that it works like it used to.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spydon spydon merged commit 7e8d3a9 into main Jul 12, 2025
8 checks passed
@spydon spydon deleted the fix/use-abs-scale-on-vertices branch July 12, 2025 22:14
nickf2k pushed a commit to nickf2k/flame that referenced this pull request Nov 16, 2025
…le for vertices (flame-engine#3642)

We broke vertically flipped hitboxes in flame-engine#3629, this fixes it up so that
it works like it used to.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants