issue/#700 Allow writeConcern to be configured as a number #701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- enables configuring Mongock with numeric writeConcern values (representing W1, W2, etc.). - previously, only "majority" or "tag set name" were supported.
Member
|
It looks good. But could you add test, please? |
- added simple test
Contributor
Author
|
dieppa
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue reference
#700
Documentation PR reference
No documentation change
Description and context
Creates WriteConcern using alternate constructor
Benefits
Allows WriteConcern as {w: 1}
Possible Drawbacks
Possibly If somebody actively used https://www.mongodb.com/docs/manual/tutorial/configure-replica-set-tag-sets/ with tag = numeric value. Instead of wanting to rely on W1, W2 ,etc
Checklist