Do not use preprocessor directives in omp_lib.h #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he `openmp/src/include` sources (#80874)" This partially reverts commit fb5fd2d, in order to remove the use of preprocessor directives in omp_lib.h, which causes the Classic Flang frontend to fail when the including source file is not preprocessed.
shivaramaarao
approved these changes
Nov 3, 2024
pawosm-arm
approved these changes
Nov 3, 2024
|
|
||
| subroutine omp_init_lock(svar) bind(c) | ||
| #ifdef __INTEL_COMPILER | ||
| !DIR$ IF(__INTEL_COMPILER.GE.1400) |
Collaborator
There was a problem hiding this comment.
So IF/ENDIF are the !DIR$ directives recognized by the Intel compiler?
Collaborator
Author
There was a problem hiding this comment.
I think so. I guess Classic Flang just ignores them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts commit fb5fd2d, in order to remove the use of preprocessor directives in omp_lib.h, which causes the Classic Flang frontend to fail when the including source file is not preprocessed.
Closes flang-compiler/flang#1451.