Skip to content
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 71 additions & 0 deletions fixtures/data/k8s_rbac_access_test.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
{
"id": "Kubernetes/test-cluster/Pod/default/nginx",
"config_class": "Pod",
"config": {
"apiVersion": "v1",
"kind": "Pod",
"metadata": {
"name": "nginx",
"namespace": "default"
}
},
"external_roles": [
{
"name": "pod-reader",
"account_id": "test-cluster",
"role_type": "ClusterRole",
"aliases": ["Kubernetes/test-cluster/ClusterRole//pod-reader"]
}
],
"external_users": [
{
"name": "my-sa",
"account_id": "test-cluster",
"user_type": "ServiceAccount",
"aliases": ["Kubernetes/test-cluster/ServiceAccount/default/my-sa"]
},
{
"name": "admin@example.com",
"account_id": "test-cluster",
"user_type": "User",
"aliases": ["Kubernetes/test-cluster/User//admin@example.com"]
}
],
"external_groups": [
{
"name": "system:authenticated",
"account_id": "test-cluster",
"group_type": "Group",
"aliases": ["Kubernetes/test-cluster/Group//system:authenticated"]
}
],
"config_access": [
{
"id": "rbac-access-sa",
"external_config_id": {
"config_type": "Kubernetes::Pod",
"external_id": "Kubernetes/test-cluster/Pod/default/nginx"
},
"external_user_aliases": ["Kubernetes/test-cluster/ServiceAccount/default/my-sa"],
"external_role_aliases": ["Kubernetes/test-cluster/ClusterRole//pod-reader"]
},
{
"id": "rbac-access-user",
"external_config_id": {
"config_type": "Kubernetes::Pod",
"external_id": "Kubernetes/test-cluster/Pod/default/nginx"
},
"external_user_aliases": ["Kubernetes/test-cluster/User//admin@example.com"],
"external_role_aliases": ["Kubernetes/test-cluster/ClusterRole//pod-reader"]
},
{
"id": "rbac-access-group",
"external_config_id": {
"config_type": "Kubernetes::Pod",
"external_id": "Kubernetes/test-cluster/Pod/default/nginx"
},
"external_group_aliases": ["Kubernetes/test-cluster/Group//system:authenticated"],
"external_role_aliases": ["Kubernetes/test-cluster/ClusterRole//pod-reader"]
}
]
}
12 changes: 12 additions & 0 deletions fixtures/file-k8s-rbac-access.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
apiVersion: configs.flanksource.com/v1
kind: ScrapeConfig
metadata:
name: file-k8s-rbac-access-scraper
spec:
full: true
file:
- type: Kubernetes::Pod
class: Pod
id: $.id
paths:
- fixtures/data/k8s_rbac_access_test.json
16 changes: 8 additions & 8 deletions scrapers/extraction_unit_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@ import (

func TestExtractConfigAccess(t *testing.T) {
testCases := []struct {
name string
input map[string]any
expectError bool
expectedCount int
expectedIDs []string
expectedUserAliases [][]string
expectedRoleAliases [][]string
expectedGroupAliases [][]string
name string
input map[string]any
expectError bool
expectedCount int
expectedIDs []string
expectedUserAliases [][]string
expectedRoleAliases [][]string
expectedGroupAliases [][]string
}{
{
name: "extracts config_access with external_user_aliases",
Expand Down
20 changes: 20 additions & 0 deletions scrapers/kubernetes/kubernetes.go
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,13 @@ func ExtractResults(ctx *KubernetesContext, objs []*unstructured.Unstructured) v

results = append(results, cluster)

// Initialize RBAC extractor for config access tracking
rbacCtx := ctx.ScrapeContext
rbacCtx.Context = rbacCtx.WithKubernetes(ctx.config.KubernetesConnection)
rbac := newRBACExtractor(rbacCtx, clusterName, ctx.ScrapeConfig().GetPersistedID())
rbac.indexObjects(objs)
var roleBindings []*unstructured.Unstructured

ctx.Load(objs)
if ctx.IsIncrementalScrape() {
// On incremental scrape, we do not have all the data in the resource ID map.
Expand Down Expand Up @@ -419,6 +426,13 @@ func ExtractResults(ctx *KubernetesContext, objs []*unstructured.Unstructured) v
}
}
}

case "ClusterRole", "Role":
rbac.processRole(obj)

case "ClusterRoleBinding", "RoleBinding":
// Store bindings for later processing after all roles are processed
roleBindings = append(roleBindings, obj)
}

if obj.GetNamespace() != "" {
Expand Down Expand Up @@ -551,6 +565,12 @@ func ExtractResults(ctx *KubernetesContext, objs []*unstructured.Unstructured) v
})
}

// Process role bindings after all roles have been processed
for _, binding := range roleBindings {
rbac.processRoleBinding(binding)
}
results = append(results, rbac.results(ctx.config.BaseScraper))

results = append(results, changeResults...)
if ctx.IsIncrementalScrape() {
results = append([]v1.ScrapeResult{ctx.cluster}, results...)
Expand Down
Loading
Loading