feat: add body_payload parameter to insert_unsent_notification_to_history #1740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tory - Add p_body_payload jsonb parameter to stored procedure - Write to body_payload column on INSERT and UPDATE - Keep p_body for backward compatibility
BenchstatBase: |
Contributor
WalkthroughThe Changes
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
views/021_notification.sql (1)
43-56: Drop the previous full signature to avoid callers hitting the old overload.Adding a new optional parameter creates a new signature; if the old signature remains, calls with the previous argument list will still resolve to the old function and never populate
body_payload. Explicitly drop the prior full signature (not just the 5‑arg one) so legacy calls route to the new function with the default value.✅ Suggested fix
-- Ensure the previous function is cleaned up. DROP FUNCTION IF EXISTS insert_unsent_notification_to_history(uuid, text, uuid, text, interval); +DROP FUNCTION IF EXISTS insert_unsent_notification_to_history( + uuid, text, uuid, text, interval, + uuid, uuid, uuid, uuid, uuid, uuid, text +);
🤖 Fix all issues with AI agents
In `@views/021_notification.sql`:
- Around line 86-89: The dedupe UPDATE is overwriting existing body_payload with
NULL when the caller omits p_body_payload; change the assignment for
body_payload in the UPDATE to preserve the stored value unless a new payload is
explicitly provided by using a conditional expression (e.g., COALESCE or CASE)
that sets body_payload = p_body_payload only when p_body_payload IS NOT NULL,
otherwise leaves the current body_payload unchanged; update the assignment
referencing body_payload and p_body_payload accordingly.
Drop the old 13-parameter function signature to prevent PostgreSQL function overloading issues where callers might hit the old function instead of the new one with body_payload parameter.
…ion_to_history - Test saving body_payload for unsent notifications - Test updating body_payload on duplicate notification (deduplication)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.