Skip to content

fix(notifications): show in_progress count separately from suppressed in summary table#2895

Open
adityathebe wants to merge 1 commit intomainfrom
fix/notification-summary-in-progress-status
Open

fix(notifications): show in_progress count separately from suppressed in summary table#2895
adityathebe wants to merge 1 commit intomainfrom
fix/notification-summary-in-progress-status

Conversation

@adityathebe
Copy link
Member

Depends on flanksource/duty#1791

Previously, notifications with pending statuses (pending, pending_playbook_run, pending_playbook_completion, evaluating-waitfor, attempting_fallback) were bucketed into suppressed by the backend and displayed as "Suppressed" in the table.

  • Added in_progress field to NotificationSendHistorySummary type
  • Renders "X in progress" badge in the Status column alongside sent/error/suppressed

@vercel
Copy link

vercel bot commented Feb 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
aws-preview Building Building Preview Feb 27, 2026 11:09am
flanksource-ui Building Building Preview Feb 27, 2026 11:09am

Request Review

@coderabbitai
Copy link

coderabbitai bot commented Feb 27, 2026

Warning

Rate limit exceeded

@adityathebe has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 8 minutes and 45 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between f5f9c44 and de94ca7.

📒 Files selected for processing (2)
  • src/api/types/notifications.ts
  • src/components/Notifications/NotificationSendHistorySummary.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/notification-summary-in-progress-status

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant