Conversation
miklezzzz
force-pushed
the
chrooted-bash-executor
branch
2 times, most recently
from
104aff1 to
bcb8093
Compare
miklezzzz
commented
Feb 10, 2025
miklezzzz
commented
Feb 10, 2025
miklezzzz
force-pushed
the
chrooted-bash-executor
branch
7 times, most recently
from
ef07ad1 to
4aa6ba0
Compare
juev
reviewed
Feb 18, 2025
Contributor
Author
|
It seems I've found other races to fix before reviewing, though. |
juev
approved these changes
Feb 19, 2025
miklezzzz
force-pushed
the
chrooted-bash-executor
branch
2 times, most recently
from
1e83eea to
b18ca92
Compare
ldmonster
approved these changes
Feb 24, 2025
Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com>
miklezzzz
force-pushed
the
chrooted-bash-executor
branch
from
b18ca92 to
ef24da5
Compare
yalosev
reviewed
Mar 4, 2025
miklezzzz
force-pushed
the
chrooted-bash-executor
branch
from
3a79135 to
f0e99c6
Compare
yalosev
approved these changes
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Implements running modules' shell scripts (hooks, enabled scripts) in a chrooted environment, prepared by a new module manager's component called environment manager.
The environment manager is enriched with the list of objects to provide in each module's chrooted directory in order to successfully launch corresponding module's scripts. Every object belongs to one of the predefined environment levels: EnabledScriptEnvironment and ShellHookEnvironment.
The resulting environment for a module is derived from the module's content (if the module has an enabled script or not, if the module has shell hooks to run or not, etc). The environment manager is capable of promoting and demoting modules' environments based on the aforementioned modules' content and the fact if a module is enabled or not.
Also, it contains several fixes to get rid of races when updating modules' states and module sets.
What this PR does / why we need it
Special notes for your reviewer